Page MenuHomePhabricator

Clean up commented-out / duplicate middleware in server.js
Open, LowPublic

Description

There are duplicate cookieParser() and body-parser lines, some active and some commented out.

Files: backend/src/server.js

Acceptance criteria:

  • Each middleware registered exactly once, in correct order
  • Dead comments removed

Event Timeline

Tiisu triaged this task as Low priority.

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

I have read and understood the task. I am working on it and will submit a patch for review shortly.

I've submitted a pull request for this task.

PR: https://github.com/Tiisu/SourceWiki/pull/40

Please let me know if any changes are needed. Thanks!

Gkm563 moved this task from Incoming to To review on the RoadToWiki board.