Page MenuHomePhabricator
Create Task
Maniphest T431274

jobs-api: resolve some env variable differences between jobs-api and webservice-cli
Closed, ResolvedPublic
Actions

Description

  • In both jobs-api and webservice-cli, HOME env is set for standard images (injected by admission webhook).
  • In webservice-cli, HOME is set for buildpack images.
  • In jobs-api, NO_HOME is set for buildpack images.
  • In webservice-cli, PORT env is set for buildpack images.
  • In jobs-api we don't set PORT env at all.

I can't recall why we have some of these differences (if you know please comment so we don't go spending time chasing this investigation).

  • why were we using NO_HOME in the first place? the value of this env (a buildservice pod does not need a home env) might be an indication that we did this because it was not needed in jobs-api.
  • do webservice-cli users depend on HOME and PORT being present for buildpack images? I can't say for sure.
  • is there are problem to just setting these in jobs-api? I don't think it breaks anything, but opinions are welcome.

Event Timeline

Raymond_Ndibe created this task.Jul 6 2026, 11:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2026, 11:11 AM
Raymond_Ndibe added a comment.EditedJul 6 2026, 3:44 PM

Decision:

  • PORT env should be added.
  • HOME env for buildservice images was added because HOME was being set to / in buildservice images without it. we could leave everything like it is right now (so HOME for webservice-cli, NO_HOME for jobs-api, shouldn't be a problem)
Raymond_Ndibe closed this task as Resolved.Jul 7 2026, 1:05 AM
Raymond_Ndibe claimed this task.
Raymond_Ndibe moved this task from Backlog to Done on the tools-platform-team board.
Raymond_Ndibe reopened this task as Open.Jul 7 2026, 1:16 AM
CodeReviewBot added a project: Patch-For-Review.Jul 7 2026, 2:04 AM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/341

k8s/jobs.py: set PORT env whenever a job exposes a port

Raymond_Ndibe moved this task from Done to In review on the tools-platform-team board.Jul 7 2026, 10:26 AM
aputhin triaged this task as High priority.Jul 8 2026, 2:40 PM
aputhin moved this task from Backlog to Stable release on the Toolforge (Push-to-Deploy) board.
CodeReviewBot added a comment.Jul 14 2026, 12:45 AM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/341

k8s/jobs.py: set PORT env whenever a job exposes a port

CodeReviewBot added a comment.Jul 14 2026, 12:49 AM

group_203_bot_3c0afd0d9fd9529f3b7bc7e69a4a3bce opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1335

jobs-api: bump to 0.0.540-20260714004554-38eaaabf

CodeReviewBot added a comment.Jul 14 2026, 1:26 AM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1335

jobs-api: bump to 0.0.540-20260714004554-38eaaabf

Maintenance_bot removed a project: Patch-For-Review.Jul 14 2026, 1:30 AM
aputhin closed this task as Resolved.Wed, Jul 29, 2:24 PM
aputhin moved this task from In review to Done on the tools-platform-team board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits