Page MenuHomePhabricator
Create Task
Maniphest T431386

Add ULS rewrite top-level component test
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

other tests can be found in T429115

This task focuses on top-level selector

  • visible state change 1307719
  • click-outside / escape / click close button 1307719
  • Mode-dependent behavior 1307847
  • Scroll Lock: Locking window scroll via classes when open in mobile mode 1309091
  • Density column: correct density class (uls-rewrite--density-low, medium, or high) 1309096
  • view panels switcher: Transitioning the view to the correct views and panel header titles. 1309634
  • Shows preferred / suggested languages 1309100
  • Search filtering 1311403
  • Accessibility - Screen-reader query announcements 1312484 1312488
  • Tab autocomplete trigger: active typeahead suggestion and fills it into the input. 1310527
  • Right arrow autocomplete trigger: active typeahead suggestion and fills it into the input. 1310527
  • Select event emitter: Clicking a language code in a list 1309619
  • Clicking an unavailable language code from the preferred list does not trigger any selection or emit events. 1309619
  • Keyboard navigation @keydown.down @Keydown.up @keydown.enter 1309168
  • Annotations (language direction) 1309638
  • ensure that correct language is highlighted 1309168
  • handling of variants 1311000
  • hide / show active language 1309676
  • (more to added)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ULS.a11y.test: add searchStatus test for screen reader announcementsHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+40 -0
ULS.keyboard.test: Add test for defaultPrevented tab key handlingHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+24 -0
ULS rewrite: add 100% coverage for LanguageListHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+82 -0
ULS.highlight.test: Add test for setHighlightedIndex helperHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+43 -0
ULS rewrite: add progressive rendering integration testHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+47 -0
ULS rewrite: test when selecting an unavailable language codeHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+4 -1
ULS rewrite: Add axe accessibility testsAbijeet Patromediawiki/extensions/UniversalLanguageSelectormaster+98 -2
ULS rewrite: Add listbox id wiring testsAbijeet Patromediawiki/extensions/UniversalLanguageSelectormaster+35 -0
LanguageSettingsEntrypoint: add 100% test coverageHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+18 -0
PreferredLanguagesTab: add 100% test coverageHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+18 -0
ULS rewrite: add 100% test coverage for index.jsHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+21 -11
ULS rewrite: Add tests for language display sortingAbijeet Patromediawiki/extensions/UniversalLanguageSelectormaster+56 -0
ULS rewrite: Add tests for all languages titleAbijeet Patromediawiki/extensions/UniversalLanguageSelectormaster+26 -0
ULS rewrite: Add more tests for close event & enter keyAbijeet Patromediawiki/extensions/UniversalLanguageSelectormaster+149 -0
ULS rewrite: add more search results test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+35 -0
ULS rewrite: add keyboard page up and down test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+66 -52
ULS rewrite: add keyboard tab, right, esc test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+79 -2
ULS rewrite: add PreferredLanguagesTab test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+78 -1
ULS rewrite: add the variants test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+107 -5
ULS rewrite: add keyboard navigation test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+72 -0
ULS rewrite: add suggestions and preferred languages test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+177 -0
ULS rewrite: add hideActiveLanguages prop test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+131 -0
ULS rewrite: Add view panels switcher testsHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+100 -1
ULS rewrite: Add select event tests for language listHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+140 -0
ULS rewrite: Add language annotations unit testHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+165 -1
ULS rewrite: add scroll lock test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+59 -0
ULS rewrite: add density column test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+87 -0
ULS rewrite: test mode behaviour on ULS componentHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+157 -0
ULS rewrite: init ULS view test specHuei Tanmediawiki/extensions/UniversalLanguageSelectormaster+419 -71
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2026, 8:11 AM
hueitan set the point value for this task to 4.Jul 7 2026, 8:12 AM
hueitan mentioned this in T429115: Add tests for the new ULS rewrite.
• Nikerabbit triaged this task as Medium priority.Jul 7 2026, 8:19 AM
gerritbot added a comment.Jul 7 2026, 11:39 AM

Change #1307719 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: init ULS view test spec

https://gerrit.wikimedia.org/r/1307719

gerritbot added a project: Patch-For-Review.Jul 7 2026, 11:39 AM

Change #1307847 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: test mode behaviour on ULS component

https://gerrit.wikimedia.org/r/1307847

hueitan updated the task description. (Show Details)Jul 8 2026, 12:41 PM
hueitan updated the task description. (Show Details)
hueitan updated the task description. (Show Details)Jul 9 2026, 8:13 AM
gerritbot added a comment.Jul 9 2026, 8:21 AM

Change #1309091 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add scroll lock test spec

https://gerrit.wikimedia.org/r/1309091

gerritbot added a comment.Jul 9 2026, 8:30 AM

Change #1309096 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add density column test spec

https://gerrit.wikimedia.org/r/1309096

hueitan updated the task description. (Show Details)Jul 9 2026, 8:33 AM
gerritbot added a comment.Jul 9 2026, 8:55 AM

Change #1309100 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add suggestions and preferred languages test spec

https://gerrit.wikimedia.org/r/1309100

hueitan updated the task description. (Show Details)Jul 9 2026, 10:13 AM
gerritbot added a comment.Jul 9 2026, 10:21 AM

Change #1307719 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: init ULS view test spec

https://gerrit.wikimedia.org/r/1307719

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.11; 2026-07-14).Jul 9 2026, 11:00 AM
abi_ subscribed.Jul 9 2026, 11:07 AM

few more things to test:

  • Annotations (language direction)
  • ensure that correct language is highlighted
  • handling of variants
  • hide / show active language
gerritbot added a comment.Jul 9 2026, 12:25 PM

Change #1309168 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add keyboard navigation test spec

https://gerrit.wikimedia.org/r/1309168

hueitan updated the task description. (Show Details)Jul 9 2026, 12:36 PM
gerritbot added a comment.Jul 9 2026, 1:05 PM

Change #1307847 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: test mode behaviour on ULS component

https://gerrit.wikimedia.org/r/1307847

gerritbot added a comment.Jul 10 2026, 9:23 AM

Change #1309619 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add select event tests for language list

https://gerrit.wikimedia.org/r/1309619

hueitan updated the task description. (Show Details)Jul 10 2026, 9:26 AM
gerritbot added a comment.Jul 10 2026, 10:19 AM

Change #1309634 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add view panels switcher tests

https://gerrit.wikimedia.org/r/1309634

hueitan updated the task description. (Show Details)Jul 10 2026, 10:23 AM
gerritbot added a comment.Jul 10 2026, 10:54 AM

Change #1309638 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add unit tests for language annotations

https://gerrit.wikimedia.org/r/1309638

hueitan updated the task description. (Show Details)Jul 10 2026, 10:57 AM
gerritbot added a comment.Jul 10 2026, 1:57 PM

Change #1309676 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add hideActiveLanguages prop test spec

https://gerrit.wikimedia.org/r/1309676

hueitan updated the task description. (Show Details)Jul 10 2026, 1:58 PM
gerritbot added a comment.Fri, Jul 10, 4:09 PM

Change #1309091 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add scroll lock test spec

https://gerrit.wikimedia.org/r/1309091

gerritbot added a comment.Fri, Jul 10, 4:09 PM

Change #1309096 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add density column test spec

https://gerrit.wikimedia.org/r/1309096

gerritbot added a comment.Sun, Jul 12, 3:31 PM

Change #1309638 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add language annotations unit test

https://gerrit.wikimedia.org/r/1309638

gerritbot added a comment.Sun, Jul 12, 4:16 PM

Change #1309619 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add select event tests for language list

https://gerrit.wikimedia.org/r/1309619

gerritbot added a comment.Mon, Jul 13, 6:45 AM

Change #1309676 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add hideActiveLanguages prop test spec

https://gerrit.wikimedia.org/r/1309676

gerritbot added a comment.Mon, Jul 13, 6:57 AM

Change #1309634 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add view panels switcher tests

https://gerrit.wikimedia.org/r/1309634

gerritbot added a comment.Mon, Jul 13, 11:58 AM

Change #1309100 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add suggestions and preferred languages test spec

https://gerrit.wikimedia.org/r/1309100

gerritbot added a comment.Tue, Jul 14, 3:03 AM

Change #1309168 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add keyboard navigation test spec

https://gerrit.wikimedia.org/r/1309168

Maintenance_bot removed a project: Patch-For-Review.Tue, Jul 14, 3:30 AM
ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.12; 2026-07-21); removed: MW-1.47-notes (1.47.0-wmf.11; 2026-07-14).Tue, Jul 14, 4:00 AM
gerritbot added a comment.Tue, Jul 14, 5:48 AM

Change #1310463 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add keyboard page up and down test spec

https://gerrit.wikimedia.org/r/1310463

gerritbot added a project: Patch-For-Review.Tue, Jul 14, 5:48 AM
gerritbot added a comment.Tue, Jul 14, 9:16 AM

Change #1310527 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add keyboard tab, right, esc test spec

https://gerrit.wikimedia.org/r/1310527

hueitan updated the task description. (Show Details)Tue, Jul 14, 9:50 AM
gerritbot added a comment.Wed, Jul 15, 10:13 AM

Change #1311000 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add the variants test spec

https://gerrit.wikimedia.org/r/1311000

hueitan updated the task description. (Show Details)Wed, Jul 15, 10:29 AM
gerritbot added a comment.Wed, Jul 15, 11:00 AM

Change #1311000 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add the variants test spec

https://gerrit.wikimedia.org/r/1311000

gerritbot added a comment.Wed, Jul 15, 3:06 PM

Change #1311070 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add PreferredLanguagesTab test spec

https://gerrit.wikimedia.org/r/1311070

gerritbot added a comment.Wed, Jul 15, 4:04 PM

Change #1311070 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add PreferredLanguagesTab test spec

https://gerrit.wikimedia.org/r/1311070

gerritbot added a comment.Thu, Jul 16, 7:43 AM

Change #1310463 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add keyboard page up and down test spec

https://gerrit.wikimedia.org/r/1310463

gerritbot added a comment.Thu, Jul 16, 7:44 AM

Change #1310527 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add keyboard tab, right, esc test spec

https://gerrit.wikimedia.org/r/1310527

Maintenance_bot removed a project: Patch-For-Review.Thu, Jul 16, 8:31 AM
gerritbot added a comment.Thu, Jul 16, 9:26 AM

Change #1311403 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add more search results test spec

https://gerrit.wikimedia.org/r/1311403

gerritbot added a project: Patch-For-Review.Thu, Jul 16, 9:26 AM
hueitan updated the task description. (Show Details)Thu, Jul 16, 9:35 AM
gerritbot added a comment.Thu, Jul 16, 3:49 PM

Change #1311403 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add more search results test spec

https://gerrit.wikimedia.org/r/1311403

Maintenance_bot removed a project: Patch-For-Review.Thu, Jul 16, 4:32 PM
gerritbot added a comment.Fri, Jul 17, 6:01 AM

Change #1311746 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add more tests for close event & enter key

https://gerrit.wikimedia.org/r/1311746

gerritbot added a project: Patch-For-Review.Fri, Jul 17, 6:02 AM

Change #1311747 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add tests for language display sorting

https://gerrit.wikimedia.org/r/1311747

gerritbot added a comment.Fri, Jul 17, 6:02 AM

Change #1311748 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add tests for all languages title

https://gerrit.wikimedia.org/r/1311748

gerritbot added a comment.Fri, Jul 17, 12:44 PM

Change #1311746 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add more tests for close event & enter key

https://gerrit.wikimedia.org/r/1311746

gerritbot added a comment.Fri, Jul 17, 12:44 PM

Change #1311747 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add tests for language display sorting

https://gerrit.wikimedia.org/r/1311747

gerritbot added a comment.Fri, Jul 17, 12:45 PM

Change #1311748 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add tests for all languages title

https://gerrit.wikimedia.org/r/1311748

Maintenance_bot removed a project: Patch-For-Review.Fri, Jul 17, 1:31 PM
gerritbot added a comment.Mon, Jul 20, 10:41 AM

Change #1312465 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] PreferredLanguagesTab: add 100% test coverage

https://gerrit.wikimedia.org/r/1312465

gerritbot added a project: Patch-For-Review.Mon, Jul 20, 10:41 AM
gerritbot added a comment.Mon, Jul 20, 11:07 AM

Change #1312470 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] LanguageSettingsEntrypoint: add 100% test coverage

https://gerrit.wikimedia.org/r/1312470

gerritbot added a comment.Mon, Jul 20, 12:20 PM

Change #1312481 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add 100% test coverage for index.js

https://gerrit.wikimedia.org/r/1312481

gerritbot added a comment.Mon, Jul 20, 12:31 PM

Change #1312484 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add axe accessibility tests

https://gerrit.wikimedia.org/r/1312484

gerritbot added a comment.Mon, Jul 20, 12:37 PM

Change #1312488 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add listbox id wiring tests

https://gerrit.wikimedia.org/r/1312488

gerritbot added a comment.Mon, Jul 20, 12:50 PM

Change #1312465 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] PreferredLanguagesTab: add 100% test coverage

https://gerrit.wikimedia.org/r/1312465

gerritbot added a comment.Mon, Jul 20, 12:56 PM

Change #1312481 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add 100% test coverage for index.js

https://gerrit.wikimedia.org/r/1312481

gerritbot added a comment.Mon, Jul 20, 1:40 PM

Change #1312470 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] LanguageSettingsEntrypoint: add 100% test coverage

https://gerrit.wikimedia.org/r/1312470

gerritbot added a comment.Mon, Jul 20, 3:00 PM

Change #1312484 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add axe accessibility tests

https://gerrit.wikimedia.org/r/1312484

gerritbot added a comment.Mon, Jul 20, 3:04 PM

Change #1312488 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add listbox id wiring tests

https://gerrit.wikimedia.org/r/1312488

Maintenance_bot removed a project: Patch-For-Review.Mon, Jul 20, 3:31 PM
gerritbot added a comment.Tue, Jul 21, 10:13 AM

Change #1313097 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add 100% coverage for LanguageList

https://gerrit.wikimedia.org/r/1313097

gerritbot added a project: Patch-For-Review.Tue, Jul 21, 10:13 AM
hueitan updated the task description. (Show Details)Tue, Jul 21, 10:24 AM
hueitan added a comment.EditedTue, Jul 21, 10:27 AM

current remaining missing coverage of ULS.vue

Line(s)Feature AreaTechnical Description

E2E browser tests related code that i would like to skip in the Unit test

Line(s)Feature AreaTechnical Description
392, 1006-1007, 1025-1026Legacy Media QueryFallback handler for mobileMediaQuery.addListener / removeListener (Safari < 14)
570-571Scroll Into ViewGuard clause in scrollHighlightedIntoView when highlightedItem is null
903-910, 914-916IME PositioningrepositionImeSelector() for repositioning IME selector on floating layout changes
925-928Focus Input GuardAsync promise wait in focusInput() until Floating UI isPositioned resolves
1016-1017Layout MeasurementInitial rowHeight measurement from DOM element (firstItem.offsetHeight) on mount
457-458, 467-468Variants FallbackFallback handling when variantLanguageCode is null or has no associated variants (NOTE: the section is never rendered, variantsTitle and currentVariantAnnotations are never accessed, making their if ( !code ) fallback branches unreachable.)
gerritbot added a comment.Tue, Jul 21, 2:09 PM

Change #1313195 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: test when selecting an unavailable language code

https://gerrit.wikimedia.org/r/1313195

gerritbot added a comment.Tue, Jul 21, 8:21 PM

Change #1313336 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add progressive integration test

https://gerrit.wikimedia.org/r/1313336

gerritbot added a comment.Wed, Jul 22, 5:32 AM

Change #1313195 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: test when selecting an unavailable language code

https://gerrit.wikimedia.org/r/1313195

gerritbot added a comment.Wed, Jul 22, 5:34 AM

Change #1313336 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add progressive rendering integration test

https://gerrit.wikimedia.org/r/1313336

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.13; 2026-07-28); removed: MW-1.47-notes (1.47.0-wmf.12; 2026-07-21).Wed, Jul 22, 6:01 AM
gerritbot added a comment.Thu, Jul 23, 9:42 AM

Change #1314731 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS.a11y.test: add searchStatus test

https://gerrit.wikimedia.org/r/1314731

gerritbot added a comment.Thu, Jul 23, 9:49 AM

Change #1314733 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS.keyboard.test: Add test for defaultPrevented tab key handling

https://gerrit.wikimedia.org/r/1314733

gerritbot added a comment.Thu, Jul 23, 10:13 AM

Change #1314743 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS.highlight.test: Add test for setHighlightedIndex helper

https://gerrit.wikimedia.org/r/1314743

hueitan updated the task description. (Show Details)Thu, Jul 23, 10:26 AM
gerritbot added a comment.Thu, Jul 23, 11:39 AM

Change #1314743 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS.highlight.test: Add test for setHighlightedIndex helper

https://gerrit.wikimedia.org/r/1314743

gerritbot added a comment.Thu, Jul 23, 1:16 PM

Change #1313097 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: add 100% coverage for LanguageList

https://gerrit.wikimedia.org/r/1313097

gerritbot added a comment.Thu, Jul 23, 3:03 PM

Change #1314733 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS.keyboard.test: Add test for defaultPrevented tab key handling

https://gerrit.wikimedia.org/r/1314733

gerritbot added a comment.Thu, Jul 23, 3:29 PM

Change #1314731 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS.a11y.test: add searchStatus test for screen reader announcements

https://gerrit.wikimedia.org/r/1314731

hueitan moved this task from In progress to Pending deployment on the LPL sprints (S1 2026 July) board.Thu, Jul 23, 3:30 PM
Maintenance_bot removed a project: Patch-For-Review.Thu, Jul 23, 3:31 PM
abi_ closed this task as Resolved.Sun, Aug 2, 5:06 PM
abi_ moved this task from Pending deployment to Owner acceptance on the LPL sprints (S1 2026 July) board.

I think we have good coverage, and all the tests have been passing on CI for the last week:

----------------------------------|---------|----------|---------|---------|---------------------------------------------------------------------
File                              | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                   
----------------------------------|---------|----------|---------|---------|---------------------------------------------------------------------
All files                         |   99.03 |    97.08 |   96.39 |   99.03 |                                                                     
 ext.uls.rewrite                  |    98.4 |    95.01 |    93.1 |    98.4 |                                                                     
  EntrypointRegistry.js           |     100 |      100 |     100 |     100 |                                                                     
  LanguageList.vue                |     100 |      100 |     100 |     100 |                                                                     
  LanguageSelectorPanelHeader.vue |     100 |      100 |     100 |     100 |                                                                     
  LanguageSettingsEntrypoint.js   |     100 |      100 |     100 |     100 |                                                                     
  PreferredLanguagesTab.vue       |     100 |      100 |     100 |     100 |                                                                     
  UniversalLanguageSelector.vue   |   97.46 |    92.93 |   86.66 |   97.46 | ...68,570-571,903-910,914-916,925-928,1006-1007,1016-1017,1025-1026 
  index.js                        |     100 |      100 |     100 |     100 |                                                                     
 ext.uls.rewrite/composables      |     100 |      100 |     100 |     100 |                                                                     
  useClickOutside.js              |     100 |      100 |     100 |     100 |                                                                     
  useCountryCode.js               |     100 |      100 |     100 |     100 |                                                                     
  useEntrypointActions.js         |     100 |      100 |     100 |     100 |                                                                     
  useEntrypoints.js               |     100 |      100 |     100 |     100 |                                                                     
  useFocusTrap.js                 |     100 |      100 |     100 |     100 |                                                                     
  useKeyboardNavigation.js        |     100 |      100 |     100 |     100 |                                                                     
  useLanguageHistory.js           |     100 |      100 |     100 |     100 |                                                                     
  usePreferredLanguages.js        |     100 |      100 |     100 |     100 |                                                                     
  useProgressiveRender.js         |     100 |      100 |     100 |     100 |                                                                     
  useSuggestedLanguages.js        |     100 |      100 |     100 |     100 |                                                                     
  useTypeahead.js                 |     100 |      100 |     100 |     100 |                                                                     
 ext.uls.rewrite/entrypoints      |     100 |      100 |     100 |     100 |                                                                     
  EmptyListEntrypoint.vue         |     100 |      100 |     100 |     100 |                                                                     
  EmptySearchEntrypoint.vue       |     100 |      100 |     100 |     100 |                                                                     
  EntrypointActionButton.vue      |     100 |      100 |     100 |     100 |                                                                     
  MissingLanguagesEntrypoint.vue  |     100 |      100 |     100 |     100 |                                                                     
  MissingLanguagesPanel.vue       |     100 |      100 |     100 |     100 |                                                                     
  QuickActionTrigger.vue          |     100 |      100 |     100 |     100 |                                                                     
  QuickActionsPanel.vue           |     100 |      100 |     100 |     100 |                                                                     
----------------------------------|---------|----------|---------|---------|---------------------------------------------------------------------

Test Suites: 39 passed, 39 total
Tests:       207 passed, 207 total
Snapshots:   0 total
Time:        3.408 s

There is nothing else to QA, so I'm inclined to mark this as done.

Thanks @hueitan

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits