Create ChangeTagsFormatter service
Closed, ResolvedPublic
Actions

Description

Summary

To assist in T386456: Feature: Allow for private, rights-restricted tags, we should make a service named ChangeTagsFormatter which centralises the formatting code for change tags. This means we can make the methods not static (as they are in ChangeTags class) and make it easier to test them

Acceptance criteria

The ChangeTagsFormatter service exists with methods from ChangeTags
The methods in ChangeTagsFormatter support rights-restricted tags
The methods in ChangeTags are hard-deprecated with the replacements being those in ChangeTagsFormatter

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
Replace use of deprecated ChangeTags::getChangeTagList	Dreamy Jazz	mediawiki/extensions/FlaggedRevs	master	+4 -2
Deprecate several ChangeTags methods	Dreamy Jazz	mediawiki/core	master	+30 -16
RL/Context: Implement LocalizationContext	Dreamy Jazz	mediawiki/core	master	+34 -5
Move change tag filter construction to ChangeTagsFormatter	Dreamy Jazz	mediawiki/core	master	+514 -157
Create SimpleLocalizationContext	Dreamy Jazz	mediawiki/core	master	+75 -0
Update ChangeTagsFormatter::formatTagsAsSummaryList for private tags	Dreamy Jazz	mediawiki/core	master	+61 -6

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• Dreamy_Jazz	T430772 DE4.1.3: Integrate personal information detection classifier into production
Resolved		MPostoronca-WMF	T431289 Update the special page displaying content policy to use the first version of the design
Resolved		ROdonoghue-WMF	T431288 Design: Create mocks for a special page to display flagged items
Resolved		• Dreamy_Jazz	T433367 Create initial special page for displaying content policy violations
Resolved		MPostoronca-WMF	T432931 Allow authorized users to add or remove the false positive tag
Resolved		MPostoronca-WMF	T431292 Tag revisions with private change tag for likely oversightable/revision deletable content
Resolved	Feature	• Dreamy_Jazz	T386456 Feature: Allow for private, rights-restricted tags
Resolved		• Dreamy_Jazz	T431414 Create ChangeTagsFormatter service

Event Timeline

• Dreamy_Jazz created this task.Jul 7 2026, 11:47 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2026, 11:47 AM

• Dreamy_Jazz moved this task from Backlog to Needs review on the Product Safety and Integrity (Sprint Venus Flytrap (Jun 29 - Jul 17)) board.Jul 7 2026, 11:47 AM

• Dreamy_Jazz updated the task description. (Show Details)Jul 7 2026, 11:50 AM

Change #1308079 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Hard deprecate ChangeTags::formatSummaryRow

https://gerrit.wikimedia.org/r/1308079

gerritbot added a project: Patch-For-Review.Jul 7 2026, 11:50 AM

• Dreamy_Jazz updated the task description. (Show Details)Jul 7 2026, 11:51 AM

Change #1308065 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Update ChangeTagsFormatter::formatTagsAsSummaryList for private tags

https://gerrit.wikimedia.org/r/1308065

Change #1308120 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Move change tag filter construction to ChangeTagsFormatter

https://gerrit.wikimedia.org/r/1308120

Change #1308065 merged by jenkins-bot:

[mediawiki/core@master] Update ChangeTagsFormatter::formatTagsAsSummaryList for private tags

https://gerrit.wikimedia.org/r/1308065

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.11; 2026-07-14).Jul 7 2026, 3:00 PM

Change #1308179 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/FlaggedRevs@master] Replace use of deprecated ChangeTags::getChangeTagList

https://gerrit.wikimedia.org/r/1308179

Change #1308181 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Deprecate several ChangeTags methods

https://gerrit.wikimedia.org/r/1308181

Tacsipacsi subscribed.Jul 7 2026, 8:06 PM

Change #1308212 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Create SimpleLocalizationContext

https://gerrit.wikimedia.org/r/1308212

Change #1308212 merged by jenkins-bot:

[mediawiki/core@master] Create SimpleLocalizationContext

https://gerrit.wikimedia.org/r/1308212

Change #1308120 merged by jenkins-bot:

[mediawiki/core@master] Move change tag filter construction to ChangeTagsFormatter

https://gerrit.wikimedia.org/r/1308120

Change #1308642 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] RL/Context: Implement LocalizationContext

https://gerrit.wikimedia.org/r/1308642

Change #1308642 merged by jenkins-bot:

[mediawiki/core@master] RL/Context: Implement LocalizationContext

https://gerrit.wikimedia.org/r/1308642

Change #1308179 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace use of deprecated ChangeTags::getChangeTagList

https://gerrit.wikimedia.org/r/1308179

Change #1308181 merged by jenkins-bot:

[mediawiki/core@master] Deprecate several ChangeTags methods

https://gerrit.wikimedia.org/r/1308181

• Dreamy_Jazz updated the task description. (Show Details)Jul 9 2026, 12:12 PM

• Dreamy_Jazz updated the task description. (Show Details)

• Dreamy_Jazz moved this task from Needs review to QA in Prod on the Product Safety and Integrity (Sprint Venus Flytrap (Jun 29 - Jul 17)) board.

This ticket should make no changes to prod, so just regression testing which we can do as part of other tickets

Create ChangeTagsFormatter serviceClosed, ResolvedPublicActions