Page MenuHomePhabricator
Create Task
Maniphest T431604

Update getMergedTo to use source_record_id if not found in first pass
Closed, ResolvedPublic
Actions

Description

Upstream follow up on T429532: Add source_record_id to merge activities that will enable T406771: Develop process to prevent direct mail being sent to long-deleted cids. An index on source_record_id already exists in core, so this will be a fast query and only run when we can't find the cid in the first query (which we'll need to maintain for backwards compat as others won't backfill, though potentially we could consider doing this query first).

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Use source_record_id for Contact::getMergedTo when merged contact has been deletedLars SGwikimedia/fundraising/crmmaster+16 -1
Customize query in gerrit

Related Objects

Event Timeline

Lars created this task.Jul 8 2026, 5:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2026, 5:37 PM
Lars moved this task from Triage to Next on the Fundraising-Backlog board.Jul 8 2026, 5:37 PM
Lars mentioned this in T406771: Develop process to prevent direct mail being sent to long-deleted cids.
Lars moved this task from Next to Current Sprint on the Fundraising-Backlog board.Jul 21 2026, 11:43 PM
Lars added a project: Fundraising Sprint: Mediocre Ikea Kit.

Upstream patch to use source_record_id as a fallback in getMergedTo

Lars moved this task from Backlog to Blocked in sprint (not fr-tech) on the Fundraising Sprint: Mediocre Ikea Kit board.Jul 21 2026, 11:44 PM
gerritbot added a comment.Jul 22 2026, 1:02 AM

Change #1313442 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/crm@master] Use source_record_id for Contact::getMergedTo when merged contact has been deleted

https://gerrit.wikimedia.org/r/1313442

gerritbot added a project: Patch-For-Review.Jul 22 2026, 1:02 AM
Lars moved this task from Blocked in sprint (not fr-tech) to Ready for Review on the Fundraising Sprint: Mediocre Ikea Kit board.Jul 22 2026, 1:02 AM
Lars claimed this task.Jul 22 2026, 1:36 PM
Ejegg moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: Mediocre Ikea Kit board.Jul 23 2026, 4:03 PM
gerritbot added a comment.Jul 23 2026, 4:22 PM

Change #1313442 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Use source_record_id for Contact::getMergedTo when merged contact has been deleted

https://gerrit.wikimedia.org/r/1313442

Lars added a comment.EditedJul 24 2026, 8:12 PM

Another upstream PR to use getMergedTo in civiimport.

Lars moved this task from Pending Deployment to Blocked in sprint (not fr-tech) on the Fundraising Sprint: Mediocre Ikea Kit board.Jul 24 2026, 8:12 PM
SBurnett-WMF edited projects, added: Fundraising Sprint: Notorious B.E.D.; removed: Fundraising Sprint: Mediocre Ikea Kit.Aug 4 2026, 6:46 PM
Lars moved this task from Backlog to Doing on the Fundraising Sprint: Notorious B.E.D. board.Aug 4 2026, 9:56 PM
Lars moved this task from Doing to Ready for Review on the Fundraising Sprint: Notorious B.E.D. board.
Lars moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: Notorious B.E.D. board.Aug 4 2026, 10:03 PM
AKanji-WMF added a project: fr-current-sprint.Aug 10 2026, 6:15 PM
Lars moved this task from Pending Deployment to Done on the Fundraising Sprint: Notorious B.E.D. board.Aug 10 2026, 9:26 PM
XenoRyet closed this task as Resolved.Aug 11 2026, 6:50 PM
XenoRyet set Final Story Points to 2.
Damilare mentioned this in T434610: Sprint N Priorities.Aug 11 2026, 8:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits