Page MenuHomePhabricator
Create Task
Maniphest T431714

Cannot move elements in long lists
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • go to https://www.wikifunctions.org/view/en/Z37431 which is a Syntactic table with 100+ options
  • click on edit
  • go to on of the options, click on the three dots next to the "Item XX"
  • select "Move before" (or "Move after"

What happens?:
The moved item as well as the item it should be moved to loose some of the Features, but the values have actually not been moved.

What should have happened instead?:
Two of the options should have been swapped.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
aw editor: Key fragments by identity so moves don't corrupt the viewGenoveva Galarzamediawiki/extensions/WikiLambdamaster+3 -1
editor: Relocate field errors when a typed-list item movesJforrestermediawiki/extensions/WikiLambdamaster+134 -0
editor: Make keyPath reactive in useZObject and useErrorJforrestermediawiki/extensions/WikiLambdamaster+82 -34
editor: Key typed-list items by identity so moves don't corrupt the viewJforrestermediawiki/extensions/WikiLambdamaster+100 -1
Customize query in gerrit

Event Timeline

DVrandecic created this task.Jul 9 2026, 2:00 PM
Prashant32194 subscribed.Jul 9 2026, 2:10 PM
Jdforrester-WMF changed the task status from Open to In Progress.Jul 9 2026, 2:24 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (27Q1 (Jul–Sep)), Essential-Work; removed: Abstract Wikipedia team.
Jdforrester-WMF triaged this task as Medium priority.Jul 10 2026, 8:32 AM
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.
Jdforrester-WMF added a comment.Jul 10 2026, 9:06 AM

The issue is that ZTypedListItems.vue keyed its v-for by array position. A "Move before"/"Move after" (offset ±1) re-orders the array, but leaves the set of indexes unchanged, so Vue re-used the two swapped child instances in place. Their local UI state (expanded/hasBeenAutoExpanded in ZObjectKeyValue and the async renderedValue cache in ZObjectToString) was never reset, so each swapped instance showed the new item's value with the old item's expansion/render state. The store move itself was always correct; this was live-view corruption only.

gerritbot added a comment.Jul 10 2026, 9:14 AM

Change #1309613 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] editor: Make keyPath reactive in useZObject and useError

https://gerrit.wikimedia.org/r/1309613

gerritbot added a project: Patch-For-Review.Jul 10 2026, 9:14 AM

Change #1309614 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] editor: Key typed-list items by identity so moves don't corrupt the view

https://gerrit.wikimedia.org/r/1309614

gerritbot added a comment.Jul 10 2026, 9:14 AM

Change #1309615 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] editor: Relocate field errors when a typed-list item moves

https://gerrit.wikimedia.org/r/1309615

Jdforrester-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.Jul 10 2026, 9:15 AM
gerritbot added a comment.Mon, Jul 13, 9:13 AM

Change #1309613 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] editor: Make keyPath reactive in useZObject and useError

https://gerrit.wikimedia.org/r/1309613

gerritbot added a comment.Mon, Jul 13, 9:45 AM

Change #1309614 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] editor: Key typed-list items by identity so moves don't corrupt the view

https://gerrit.wikimedia.org/r/1309614

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.11; 2026-07-14).Mon, Jul 13, 10:02 AM
gerritbot added a comment.Mon, Jul 13, 10:29 AM

Change #1309615 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] editor: Relocate field errors when a typed-list item moves

https://gerrit.wikimedia.org/r/1309615

Maintenance_bot removed a project: Patch-For-Review.Mon, Jul 13, 10:30 AM
Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.Mon, Jul 13, 1:02 PM
gerritbot added a comment.Mon, Jul 13, 2:30 PM

Change #1310113 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] aw editor: Key fragments by identity so moves don't corrupt the view

https://gerrit.wikimedia.org/r/1310113

gerritbot added a project: Patch-For-Review.Mon, Jul 13, 2:30 PM
gerritbot added a comment.Mon, Jul 13, 3:37 PM

Change #1310113 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] aw editor: Key fragments by identity so moves don't corrupt the view

https://gerrit.wikimedia.org/r/1310113

Maintenance_bot removed a project: Patch-For-Review.Mon, Jul 13, 4:31 PM
gengh moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.Tue, Jul 28, 1:28 PM
Jdforrester-WMF closed this task as Resolved.Tue, Jul 28, 1:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits