Page MenuHomePhabricator
Create Task
Maniphest T431779

Add NotEmpty validator to Phabricator
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

To deal with problems like https://translatewiki.net/wiki/Support/Archive/2026/01#More_empty_translations

There at least one message that is deliberately the empty string (phabricator-core-da39a3ee5e6b4b0d), but it's ignored, and I don't think validators apply to ignored messages). Aside from that a quick grep -r ": \"\" projects shows 1000 empty messages, mostly in Turkish and Portuguese.

QA plan

After deployment, non-admin account should not be able to make an empty translation for Phabricator.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Phabricator: Add NotEmpty validatorPpperytranslatewikimaster+2 -0
Customize query in gerrit

Event Timeline

Pppery created this task.Jul 10 2026, 3:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2026, 3:41 AM
gerritbot added a comment.Jul 10 2026, 5:45 PM

Change #1309706 had a related patch set uploaded (by Pppery; author: Pppery):

[translatewiki@master] Phabricator: Add NotEmpty validator

https://gerrit.wikimedia.org/r/1309706

gerritbot added a project: Patch-For-Review.Jul 10 2026, 5:45 PM
gerritbot added a comment.Jul 13 2026, 9:16 AM

Change #1309706 merged by jenkins-bot:

[translatewiki@master] Phabricator: Add NotEmpty validator

https://gerrit.wikimedia.org/r/1309706

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2026, 9:31 AM
• Nikerabbit triaged this task as Low priority.Jul 13 2026, 11:00 AM
• Nikerabbit added projects: Community-collaboration, LPL sprints, LPL Projects (Ongoing maintenance), Essential-Work.
• Nikerabbit set the point value for this task to 1.
Aklapper assigned this task to Pppery.Jul 13 2026, 11:20 AM
• Nikerabbit moved this task from Backlog to Needs refinement on the LPL sprints board.Jul 13 2026, 11:59 AM
• Nikerabbit updated the task description. (Show Details)Jul 13 2026, 12:04 PM
• Nikerabbit subscribed.

I tried to test this but I see no indication anywhere that it would be working. But need to be confirmed by a non-admin account.

• Nikerabbit edited projects, added: LPL sprints (S1 2026 July); removed: LPL sprints.Jul 13 2026, 12:59 PM
• Nikerabbit moved this task from Ready for dev to Needs QA on the LPL sprints (S1 2026 July) board.
Pppery closed this task as Resolved.Jul 13 2026, 2:48 PM

Works for me.

• Nikerabbit moved this task from Needs QA to Owner acceptance on the LPL sprints (S1 2026 July) board.Jul 14 2026, 6:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits