Page MenuHomePhabricator

If a task type is undeployed, Suggested Edits might misbehave for certain users
Open, MediumPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

NOTE: Those steps to reproduce are incomplete. The issue appeared when I had revise-tone in se-filters and disappeared when I reset that property to a default value. However, retrospectively following those steps does not cause the problem. P94786 is a dump of my user properties at the time of seeing that bug. https://test.wikipedia.org/w/index.php?title=MediaWiki:GrowthExperimentsSuggestedEdits.json&diff=prev&oldid=750689 also happened at around the reproduction of this bug. I was also playing with new mw.Api().saveOption('growthexperiments-homepage-suggestededits-activated', null) at that time.

Visit Special:Homepage with an account that has a task type selected (in growthexperiments-homepage-se-filters) which is no longer available. An artificial way to do this can be:

  • Call new mw.Api().saveOption('growthexperiments-homepage-se-filters', "[\"revise-tone\"]") in your browser console
  • Go to Special:Homepage

What happens?:

The task type selector is unusable (no task types were provided)

What should have happened instead?:

Task type selector was operating normally.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This is also what I had in my console (recovered from Logstash):

Error: Unknown task type revise-tone
at new TaskExplanationWidget  https://test.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=1yst4:415:547
at SuggestedEditsModule.js.SuggestedEditsModule.updateTaskExplanationWidget  https://test.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=1yst4:400:162
at SuggestedEditsModule.js.SuggestedEditsModule.updateControls  https://test.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=1yst4:404:866
at SuggestedEditsModule.js.SuggestedEditsModule.onNewcomerTasksDataChanged  https://test.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=1yst4:400:490
at OO.EventEmitter.emit  https://test.wikipedia.org/w/load.php?lang=en&modules=oojs&skin=vector-2022&version=rwdvu:8:193
at NewcomerTasksStore.onTaskQueueChanged  https://test.wikipedia.org/w/load.php?lang=en&modules=ext.growthExperiments.DataStore&skin=vector-2022&version=1637y:10:390
at NewcomerTasksStore.setPreloadedTaskQueue  https://test.wikipedia.org/w/load.php?lang=en&modules=ext.growthExperiments.DataStore&skin=vector-2022&version=1637y:9:974
at initSuggestedTasks  https://test.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=1yst4:391:196
at https://test.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=1yst4:392:692
at index.js  https://test.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=1yst4:392:982