Page MenuHomePhabricator
Create Task
Maniphest T431929

Clicking login drops me into dark mode
Open, MediumPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Be logged out on desktop. Light mode is selected.
  • Click login

What happens?:

  • Switches to dark mode on Special:Login

What should have happened instead?:
Stayed on light mode.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Been a week or two of this.

Firefox 151 for Linux.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Vector: Respect user theme choice in native browser controlsArpitajain28mediawiki/skins/Vectormaster+76 -1
Customize query in gerrit

Event Timeline

Izno created this task.Sat, Jul 11, 4:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Jul 11, 4:39 PM
Izno updated the task description. (Show Details)Sat, Jul 11, 4:40 PM
Izno added a project: MediaWiki-User-login-and-signup.
Anirudh_KK subscribed.Sat, Jul 11, 5:28 PM
gerritbot added a comment.Sun, Jul 12, 1:48 PM

Change #1309854 had a related patch set uploaded (by Arpitajain28; author: Arpitajain28):

[mediawiki/skins/Vector@master] Vector: Respect user theme choice in native browser controls

https://gerrit.wikimedia.org/r/1309854

gerritbot added a project: Patch-For-Review.Sun, Jul 12, 1:48 PM
Alien333 subscribed.Sun, Jul 12, 5:54 PM
Arpitajain28 claimed this task.Sun, Jul 12, 6:45 PM
Arpitajain28 subscribed.

i have submitted a patch for this task. please review it

Arpitajain28 added a project: RoadToWiki.Sun, Jul 12, 6:47 PM
Adarsh2406 moved this task from Incoming to To review on the RoadToWiki board.Wed, Jul 15, 11:33 AM
Jdlrobson-WMF added a project: Reader Experience Team.Wed, Jul 22, 1:12 PM
HFan-WMF triaged this task as Medium priority.Tue, Jul 28, 12:28 AM
HFan-WMF moved this task from Incoming to Backlog on the Reader Experience Team board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits