Page MenuHomePhabricator

Error warning in Commons upload wizard appears after submission
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Begin uploading some images to Commons
  • Include at least one with a nonexistent category
  • Click publish

What happens?:
As the images are publishing, a notice appears at the bottom saying something like "There is at least one error with the submissions above. We recommend correcting it before continuing."

What should have happened instead?:
This notice should not have appeared, since by the time the user clicks "Publish" the images are already being published, so it is too late to take action on any warning.

Event Timeline

Sdkb renamed this task from Error warning in Common upload wizard appears after submission to Error warning in Commons upload wizard appears after submission.Sun, Jul 12, 4:01 AM

Change #1309840 had a related patch set uploaded (by Anirudh_K; author: Anirudh_K):

[mediawiki/extensions/UploadWizard@master] fix(UploadWizard): clear error summary on successful publish

https://gerrit.wikimedia.org/r/1309840

Anirudh_KK added a project: RoadToWiki.

Claiming this task! I've tracked down the issue to the .always() validation handler triggering the error summary even when the form is valid and proceeding to submit. I have pushed a patch for review that changes this to only show the summary on validation failures.

@Sdkb, Just a quick heads-up that I have uploaded a patch set (Change #1309840) to address this issue. Whenever someone has some cycles to spare, I'd appreciate a quick look/review. Thank you!

@Sdkb Could you give a screenshot of this warning? I can't pinpoint the issue here :)

@Soda I created a screengrab, but Phabricator won't let me upload it because it's too large. Will DM you on Discord with it (and if anyone else wants it, lmk).