Steps to replicate the issue (include links if applicable):
What happens?:
User Y and User X are both unblocked.
What should have happened instead?:
Only User Y should have been unblocked, since User X's block was out of the selected time interval.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T209023 Major overhaul for AbuseFilter | |||
| Open | None | T433700 Improve AbuseFilter's revert functionality | |||
| Resolved | BUG REPORT | Abhinavwikiclub | T431941 abusefilter-revert reverting actions out of selected time interval |
Change #1309852 had a related patch set uploaded (by Anirudh_K; author: Anirudh_K):
[mediawiki/extensions/AbuseFilter@master] fix: preserve time interval when reverting actions
Hi @Abhinavwikiclub,
I didn't see that you had claimed this task until just now, but I have already written a fix and submitted a patch for this issue on Gerrit .
Since my patch is already up for review, you might want to look for another task for your contributions to avoid duplicating effort. Best of luck with your other contributions!
Change #1309857 had a related patch set uploaded (by Abhinavwikigerrit; author: Abhinavwikigerrit):
[mediawiki/extensions/AbuseFilter@master] AbuseFilter: Preserve selected period in revert confirmation
Change #1309852 had a related patch set uploaded (by Aklapper; author: Anirudh_K):
[mediawiki/extensions/AbuseFilter@master] fix preserve time interval when reverting actions
Change #1309852 abandoned by Anirudh_K:
[mediawiki/extensions/AbuseFilter@master] AbuseFilter: Fix time interval bug on confirmation form
Reason:
bandoning this patchset. The testRevertTimeInterval test kept surfacing permission-related failures during review PermissionsError on abusefilter-view, plus earlier CI failures, and given other priorities, I don't have bandwidth to keep iterating on this right now. Happy to have someone else pick it up, or I may revisit later. Thanks for the reviews and feedback so far.
Change #1309857 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] AbuseFilter: Preserve selected period in revert confirmation