Page MenuHomePhabricator

VisualEditor: Paragraph containing nowiki block does not change style unless block selected
Closed, ResolvedPublic

Description

Heading 1a

<nowiki>[[File:VectorEditorBasic-en.png]]</nowiki>

Heading 2aa

  1. Put cursor at end of nowiki line
  2. Select a different style
  3. Problem: Style not applied

The style is applied if the line contains simple text instead.
The style is applied if selecting the whole nowiki line instead of just putting the cursor at end of line.

I guess nowiki in headers is not usual, though.


Version: unspecified
Severity: normal

Details

Reference
bz41203

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:02 AM
bzimport set Reference to bz41203.
Inez added a comment.Feb 8 2013, 10:10 PM

Can't reproduce. Note that it is nowiki in paragraph, not in a header.

This is a bug in newFromContentBranchConversion(), and is caused by selectNodes() returning the paragraph rather than a text node, because the selection is between the open/closing paragraph and the alien.

Merged and will go out in the deploy train tomorrow.