Page MenuHomePhabricator
Create Task
Maniphest T432071

Section edit link brackets are wrapping poorly
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
DLynch
Mon, Jul 13, 10:22 PM
Project Tags
Referenced Files
F94974140: Screenshot 2026-07-21 at 06-44-16 Global catastrophic risk - Wikipedia.png
Mon, Jul 27, 6:52 PM
File Not Attached
F95036100: Screenshot 2026-07-21 at 15-55-24 Global catastrophic risk - Wikipedia.png
Tue, Jul 21, 12:56 PM
F93466036: CleanShot 2026-07-13 at 17.16.51@2x.png
Mon, Jul 13, 10:22 PM
Subscribers
Aklapper
DLynch
Izno
matmarex
Qbli2mHd
Tacsipacsi

Description

The section edit links look like [ edit | edit source ] and are in a <span class="mw-editsection"> following the heading tag inside a <div class="mw-heading">.

The brackets surrounding them wrap separately from the links, which doesn't look very good:

CleanShot 2026-07-13 at 17.16.51@2x.png (1,992×238 px, 71 KB)

Ideally what would happen would be one of:

  1. The bracket binds to the link within it ([ edit\n | edit source ] (sort of awkward because then we have to choose how the separator binds)
  2. The entire mw-editsection wraps as a unit

These two cases are identical on single-tab wikis since the user will only see [ edit ] or [ edit source ] there.

This might be a regression from the changes for T268900, I'm not sure. It could also have been around for ages and I only just happened to notice it.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update styles for hiding VE section edit link on no-JSBartosz Dziewońskimediawiki/extensions/VisualEditormaster+22 -3
Improve line breaking around section edit linksBartosz Dziewońskimediawiki/coremaster+16 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

DLynch created this task.Mon, Jul 13, 10:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Jul 13, 10:22 PM
Esanders added a project: Regression.Mon, Jul 13, 10:47 PM
gerritbot added a comment.Wed, Jul 15, 10:23 PM

Change #1311124 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Improve line breaking around section edit links

https://gerrit.wikimedia.org/r/1311124

gerritbot added a project: Patch-For-Review.Wed, Jul 15, 10:23 PM

Change #1311125 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update styles for hiding VE section edit link on no-JS

https://gerrit.wikimedia.org/r/1311125

matmarex claimed this task.Wed, Jul 15, 10:25 PM

Ideally what would happen would be one of:

  1. The bracket binds to the link within it ([ edit\n | edit source ] (sort of awkward because then we have to choose how the separator binds)

It was a bit tricky, but I got that to work. It looks better to me when the separator binds to the preceding link, so I made it work that way, although the other way is also doable.

One drawback of the solution I found is that it makes it more difficult to hide individual links with CSS without removing them from the DOM/HTML. As far as I know we only do that in VisualEditor (to hide the VE link in no-JS), so I hope we can live with that, but if it causes more problems, we can always do option 2, which is much easier (just revert and add white-space: nowrap).

  1. The entire mw-editsection wraps as a unit

I'd rather avoid that, since that unit can be pretty long,. when you have both links, like [ edit | edit source ] (and perhaps even three or more, like [ edit | edit source | share ]).

matmarex added a parent task: T268900: Clean up section edit link brackets.Wed, Jul 15, 10:36 PM
Izno subscribed.Wed, Jul 15, 11:14 PM
In T432071#12126306, @matmarex wrote:
  1. The entire mw-editsection wraps as a unit

I'd rather avoid that, since that unit can be pretty long,. when you have both links, like [ edit | edit source ] (and perhaps even three or more, like [ edit | edit source | share ]).

And the English wording of links can be generously short. Other languages are much longer.

PatchDemoBot added a comment.Thu, Jul 16, 3:33 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://4af7ceaa13.catalyst.wmcloud.org/wiki/Douglas Adams

gerritbot added a comment.Thu, Jul 16, 3:53 PM

Change #1311124 merged by jenkins-bot:

[mediawiki/core@master] Improve line breaking around section edit links

https://gerrit.wikimedia.org/r/1311124

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.12; 2026-07-21).Thu, Jul 16, 4:00 PM
gerritbot added a comment.Thu, Jul 16, 4:18 PM

Change #1311125 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update styles for hiding VE section edit link on no-JS

https://gerrit.wikimedia.org/r/1311125

Maintenance_bot removed a project: Patch-For-Review.Thu, Jul 16, 4:31 PM
matmarex closed this task as Resolved.Fri, Jul 17, 5:35 AM
NguoiDungKhongDinhDanh mentioned this in T432678: Awkward placement of [ edit | edit source ] links with a line break.Tue, Jul 21, 5:32 AM
NguoiDungKhongDinhDanh merged a task: T432678: Awkward placement of [ edit | edit source ] links with a line break.Tue, Jul 21, 5:46 AM
NguoiDungKhongDinhDanh added a subscriber: Qbli2mHd.
Qbli2mHd added a comment.Tue, Jul 21, 12:56 PM
In T432071#12126306, @matmarex wrote:

I'd rather avoid that, since that unit can be pretty long,. when you have both links, like [ edit | edit source ]

This looks clumsy though

Screenshot 2026-07-21 at 15-55-24 Global catastrophic risk - Wikipedia.png (522×88 px, 5 KB)

matmarex added a comment.Thu, Jul 23, 1:40 AM

How do you think it should look?

Tacsipacsi subscribed.Fri, Jul 24, 1:24 PM
In T432071#12148420, @matmarex wrote:

How do you think it should look?

I’d at least put the pipe before the line break, similar to how hlist dots are on the previous line, hyphenation happens on the previous line etc.

matmarex added a comment.Sat, Jul 25, 9:11 PM

The pipe is already being placed before the line break. That screenshot must have been taken before the patch from this task was deployed.

Tacsipacsi added a comment.Sun, Jul 26, 4:55 PM

I see, thanks for having implemented my wish before I said it! ☺

Qbli2mHd added a comment.Mon, Jul 27, 6:52 PM
In T432071#12148420, @matmarex wrote:

How do you think it should look?

With links grouped together after the line break

Screenshot 2026-07-21 at 06-44-16 Global catastrophic risk - Wikipedia.png (522×103 px, 5 KB)
instead of placing them in opposite corners of the block which happens now. These are two options to perform the same task, and keeping them apart is not good.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits