Page MenuHomePhabricator

HeadingLevel edit check does not dismiss
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open VE on an article with a HeadingLevel suggestion (or type a false heading to trigger the check).
  • Click dismiss.

What happens?:
The action card remains as it was.

What should have happened instead?:
The action card should be dismissed.

Other information (browser name/version, screenshots, etc.):
https://youtu.be/WxW9gxU_glU
Also, there's no error in the console when this happens.

Event Timeline

Change #1310628 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] HeadingLevelEditCheck: Fix dismiss ranges

https://gerrit.wikimedia.org/r/1310628

Change #1310628 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] HeadingLevelEditCheck: Fix dismiss ranges

https://gerrit.wikimedia.org/r/1310628

DLynch assigned this task to Esanders.
DLynch added a project: Skipped QA.