Page MenuHomePhabricator
Create Task
Maniphest T432157

Too many rows read by queries in SuggestedInvestigationsSharedPagesLookup
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Summary

The SuggestedInvestigationsSharedPagesLookup::getUndeletedPagesEditedByUsers method appears to lack batching and is causing query warnings for selecting too many rows in a single query

Error
  • mwversion: 1.47.0-wmf.10
  • timestamp: 2026-07-14T12:15:16.751Z
  • phpversion: 8.3.31
  • reqId: 09448671-1c32-486e-a390-d3f148cfc47d
  • Find reqId in Logstash
normalized_message
Expectation (readQueryRows <= 10000) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: {actualSeconds}) in trx #{trxId}:
{query}
FrameLocationCall
from/srv/mediawiki/php-1.47.0-wmf.10/includes/libs/Rdbms/TransactionProfiler.php(602)
#0/srv/mediawiki/php-1.47.0-wmf.10/includes/libs/Rdbms/TransactionProfiler.php(368)Wikimedia\Rdbms\TransactionProfiler->reportExpectationViolated(string, Wikimedia\Rdbms\GeneralizedSql, int, string, string)
#1/srv/mediawiki/php-1.47.0-wmf.10/includes/libs/Rdbms/Database/TransactionManager.php(572)Wikimedia\Rdbms\TransactionProfiler->recordQueryCompletion(Wikimedia\Rdbms\GeneralizedSql, float, bool, int, string, string, string)
#2/srv/mediawiki/php-1.47.0-wmf.10/includes/libs/Rdbms/Database/Database.php(850)Wikimedia\Rdbms\TransactionManager->recordQueryCompletion(Wikimedia\Rdbms\GeneralizedSql, float, bool, int, string, string)
#3/srv/mediawiki/php-1.47.0-wmf.10/includes/libs/Rdbms/Database/Database.php(708)Wikimedia\Rdbms\Database->attemptQuery(Wikimedia\Rdbms\Query, string, bool)
#4/srv/mediawiki/php-1.47.0-wmf.10/includes/libs/Rdbms/Database/Database.php(635)Wikimedia\Rdbms\Database->executeQuery(Wikimedia\Rdbms\Query, string, int)
#5/srv/mediawiki/php-1.47.0-wmf.10/includes/libs/Rdbms/Database/Database.php(1369)Wikimedia\Rdbms\Database->query(Wikimedia\Rdbms\Query, string)
#6/srv/mediawiki/php-1.47.0-wmf.10/includes/libs/Rdbms/Database/DBConnRef.php(129)Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#7/srv/mediawiki/php-1.47.0-wmf.10/includes/libs/Rdbms/Database/DBConnRef.php(381)Wikimedia\Rdbms\DBConnRef->__call(string, array)
#8/srv/mediawiki/php-1.47.0-wmf.10/includes/libs/Rdbms/QueryBuilder/SelectQueryBuilder.php(761)Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
#9/srv/mediawiki/php-1.47.0-wmf.10/extensions/CheckUser/src/SuggestedInvestigations/Services/SuggestedInvestigationsSharedPagesLookup.php(156)Wikimedia\Rdbms\SelectQueryBuilder->fetchResultSet()
#10/srv/mediawiki/php-1.47.0-wmf.10/extensions/CheckUser/src/SuggestedInvestigations/Services/SuggestedInvestigationsSharedPagesLookup.php(82)MediaWiki\Extension\CheckUser\SuggestedInvestigations\Services\SuggestedInvestigationsSharedPagesLookup->getUndeletedPagesEditedByUsers(array)
#11/srv/mediawiki/php-1.47.0-wmf.10/extensions/CheckUser/src/SuggestedInvestigations/Pagers/SuggestedInvestigationsCasesPager.php(761)MediaWiki\Extension\CheckUser\SuggestedInvestigations\Services\SuggestedInvestigationsSharedPagesLookup->getSharedPagesForCases(array)
#12/srv/mediawiki/php-1.47.0-wmf.10/extensions/CheckUser/src/SuggestedInvestigations/Pagers/SuggestedInvestigationsCasesPager.php(730)MediaWiki\Extension\CheckUser\SuggestedInvestigations\Pagers\SuggestedInvestigationsCasesPager->addMetadataToCases(array)
#13/srv/mediawiki/php-1.47.0-wmf.10/includes/Pager/IndexPager.php(259)MediaWiki\Extension\CheckUser\SuggestedInvestigations\Pagers\SuggestedInvestigationsCasesPager->reallyDoQuery(string, int, bool)
#14/srv/mediawiki/php-1.47.0-wmf.10/includes/Pager/IndexPager.php(903)MediaWiki\Pager\IndexPager->doQuery()
#15/srv/mediawiki/php-1.47.0-wmf.10/includes/Pager/CodexTablePager.php(280)MediaWiki\Pager\IndexPager->isNavigationBarShown()
#16/srv/mediawiki/php-1.47.0-wmf.10/includes/Pager/CodexTablePager.php(59)MediaWiki\Pager\CodexTablePager->getNavigationBar()
#17/srv/mediawiki/php-1.47.0-wmf.10/extensions/CheckUser/src/SuggestedInvestigations/Pagers/SuggestedInvestigationsCasesPager.php(1228)MediaWiki\Pager\CodexTablePager->getFullOutput()
#18/srv/mediawiki/php-1.47.0-wmf.10/extensions/CheckUser/src/SuggestedInvestigations/SpecialSuggestedInvestigations.php(134)MediaWiki\Extension\CheckUser\SuggestedInvestigations\Pagers\SuggestedInvestigationsCasesPager->getFullOutput()
#19/srv/mediawiki/php-1.47.0-wmf.10/includes/SpecialPage/SpecialPage.php(727)MediaWiki\Extension\CheckUser\SuggestedInvestigations\SpecialSuggestedInvestigations->execute(null)
#20/srv/mediawiki/php-1.47.0-wmf.10/includes/SpecialPage/SpecialPageFactory.php(1723)MediaWiki\SpecialPage\SpecialPage->run(null)
#21/srv/mediawiki/php-1.47.0-wmf.10/includes/Actions/ActionEntryPoint.php(505)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#22/srv/mediawiki/php-1.47.0-wmf.10/includes/Actions/ActionEntryPoint.php(145)MediaWiki\Actions\ActionEntryPoint->performRequest()
#23/srv/mediawiki/php-1.47.0-wmf.10/includes/MediaWikiEntryPoint.php(180)MediaWiki\Actions\ActionEntryPoint->execute()
#24/srv/mediawiki/php-1.47.0-wmf.10/index.php(44)MediaWiki\MediaWikiEntryPoint->run()
#25/srv/mediawiki/w/index.php(3)require(string)
#26{main}

Details

Request URL
https://commons.wikimedia.org/wiki/Special:SuggestedInvestigations
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix too many rows read warning in SuggestedInvestigationsSharedPagesLookupAkaza24mediawiki/extensions/CheckUsermaster+4 -2
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Jul 14 2026, 5:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2026, 5:48 PM
Dreamy_Jazz edited projects, added: Product Safety and Integrity (Sprint Venus Flytrap (Jun 29 - Jul 17)); removed: Product Safety and Integrity.Jul 14 2026, 5:48 PM
Akaza24 subscribed.Jul 14 2026, 9:03 PM
gerritbot added a comment.Jul 15 2026, 9:19 AM

Change #1310657 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Fix too many rows read warning in SuggestedInvestigationsSharedPagesLookup

https://gerrit.wikimedia.org/r/1310657

Dreamy_Jazz assigned this task to Akaza24.Jul 15 2026, 9:52 AM
Dreamy_Jazz moved this task from Backlog to Needs review on the Product Safety and Integrity (Sprint Venus Flytrap (Jun 29 - Jul 17)) board.
Dreamy_Jazz moved this task from Needs review to QA in Prod on the Product Safety and Integrity (Sprint Venus Flytrap (Jun 29 - Jul 17)) board.
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.12; 2026-07-21).Jul 15 2026, 10:00 AM
Akaza24 added a project: RoadToWiki.Jul 15 2026, 11:23 AM
Adarsh2406 moved this task from Incoming to Completed on the RoadToWiki board.Jul 15 2026, 11:24 AM
OKryva-WMF moved this task from Backlog to In Progress on the CheckUser-SuggestedInvestigations board.Jul 20 2026, 7:28 AM
OKryva-WMF edited projects, added: Product Safety and Integrity (Sprint Clover (Jul 20 - Aug 7)); removed: Product Safety and Integrity (Sprint Venus Flytrap (Jun 29 - Jul 17)).Jul 20 2026, 2:02 PM
OKryva-WMF moved this task from Backlog to QA in Prod on the Product Safety and Integrity (Sprint Clover (Jul 20 - Aug 7)) board.Jul 20 2026, 2:02 PM
OKryva-WMF edited projects, added: Product Safety and Integrity (Sprint Sunflower (Aug 11 - Aug 28)); removed: Product Safety and Integrity (Sprint Clover (Jul 20 - Aug 7)).Aug 11 2026, 1:55 PM
OKryva-WMF moved this task from Backlog to QA in Prod on the Product Safety and Integrity (Sprint Sunflower (Aug 11 - Aug 28)) board.Aug 11 2026, 1:55 PM
Dreamy_Jazz closed this task as Resolved.Thu, Aug 27, 9:31 AM
Dreamy_Jazz moved this task from QA in Prod to Done on the Product Safety and Integrity (Sprint Sunflower (Aug 11 - Aug 28)) board.

The logs are no longer occuring

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits