Page MenuHomePhabricator
Create Task
Maniphest T432160

Erroneous capitalization of first letter when importing lists into AWB from text file, when logged-out but with the project set to a case-sensitive wiki like en.Wiktionary
Closed, ResolvedPublic
Actions

Description

I noticed today when importing a list from a UTF-8 text file that AWB now capitalizes the first letters of all imported terms (e.g. the list has "foo" but AWB imports this as "Foo"), even when I set the wiki to en.wiktionary, where case matters and most entries are not capitalized. (If I import e.g. the contents of a category, they are imported as expected, without erroneous capitalization.) The issue persists even after I updated to version 6.5.0.0.

The older, expected, and desired behavior would be for it to import the list without changing it, i.e. import "foo" as "foo".

(It looks like the same problem occurred and was fixed at least once before in the distant past, if knowing @Rjwilmsi 's old 2010 fix helps anyone fix it again.)

Event Timeline

-sche created this task.Tue, Jul 14, 6:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Jul 14, 6:35 PM
-sche updated the task description. (Show Details)Tue, Jul 14, 6:56 PM
-sche updated the task description. (Show Details)
-sche added a subscriber: Rjwilmsi.
Rjwilmsi added a comment.Wed, Jul 15, 8:15 AM

@-sche Were you logged in to Wiktionary at the time (not just setting that in preferences)? The code you link to (rev 7310) is still there.

Rjwilmsi moved this task from Backlog to User input needed on the AutoWikiBrowser board.Wed, Jul 15, 8:16 AM
-sche added a comment.Wed, Jul 15, 4:22 PM

Insightful question! I was not logged in at the time, and when I log in now, I see that a list can be imported from a text file without the erroneous capitalization bug if I am logged-in. 😮🤔 That's an interesting difference in behavior, and (IMO) still seems like a bug, as I would expect importing from a text file to work whenever the correct project is set (down in the lower right corner of the interface), not only when logged-in : other things, e.g. pulling all the redlinks off a page, work as expected (pull from the correct project, and don't add erroneous capitalization) whenever the correct project is set, without requiring that the user be logged-in.

-sche renamed this task from Erroneous capitalization of first letter when importing lists into AWB from a text file to Erroneous capitalization of first letter when importing lists into AWB from text file, when logged-out but with the project set to a case-sensitive wiki like en.Wiktionary.Wed, Jul 15, 4:23 PM
Rjwilmsi closed this task as Resolved.Sat, Jul 18, 1:53 PM
Rjwilmsi claimed this task.

In the general case, we can't apply the right settings until the user logs in because a private wiki may not give us the information until after user log in. However, we can set the correct default for wiktionary.

rev 13038 When setting project, default CapitalizeFirstLetter to false for wiktionary, so list maker doesn't enforce first letter upper on page titles when user hasn't logged in

Will be in next release of AWB.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits