Page MenuHomePhabricator

StarterKit misdetects HotCat preference as disabled on wikis that register the gadget under a different id
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

The HotCat task's preference check queries meta=userinfo&uiprop=options and looks up the hardcoded option keys gadget-HotCat / gadget-Hotcat. But the option key follows whatever id the wiki registers in MediaWiki:Gadgets-definition, and ids vary: el.wikipedia.org registers the gadget as HotCats, so the user's options contain only gadget-HotCats and the lookup finds nothing.

Steps to replicate the issue (include links if applicable):

  • Log in to Starter Kit with a wiki whose HotCat gadget id isn't exactly HotCat/Hotcat (e.g. el.wikipedia.org) and HotCat enabled in your preferences.
  • Open the "Install HotCat" task, step 1.

What happens?:
The card warns the gadget is disabled in your preferences, and the Continue button is disabled — blocking the task.

What should have happened instead?:
The preference card should show HotCat as enabled and Continue should be available.

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Fix: Derive HotCat gadget id from Gadgets-definitionrepos/lpl/starterkit-v1!120ngkountasfix/hotcat-gadget-id-derivationmain
Customize query in GitLab

Event Timeline

ngkountas triaged this task as High priority.
ngkountas moved this task from Blocked to In Progress on the LPL Onboarding and Development board.
ngkountas set the point value for this task to 1.

In my conversation with @SGill yesterday, it came up that even though HotCat was enabled for him in the preferences on Punjabi Wiki, he was not able to proceed. He tried logging in with both his staff and personal accounts, but the issue persisted. I don't recall the exact flow, so I'll ask him to add more details to this task.

@srishakatux This is interesting, I'd like to have some more details to try and reproduce the issue. From my side I don't experience any such issues in Punjabi Wiki as demonstrated in the screencast below. Satdeep's issue doesn't sound to be related to this task, but we can keep this open, until we get more information.

This comment was removed by SGill.

Right! I tested that and turns out this task was not about the gadget but my personal preferences.

Thanks @SGill for your comment. It looks like we can close this task now. Thanks @ngkountas for documenting additional steps as well.