Page MenuHomePhabricator
Create Task
Maniphest T432185

Add daf_contact_id to Acoustic export
Open, HighPublic
Actions

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Also fill daf_contact_id with the contact's own id when they have a DAF giftLars SGwikimedia/fundraising/toolsmaster+34 -7
Add daf_contact_id to Acoustic exportLars SGwikimedia/fundraising/toolsmaster+83 -2
Add triggers from relationship table to set contact modified_dateLars SGwikimedia/fundraising/crmmaster+30 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lars created this task.Tue, Jul 14, 11:38 PM
gerritbot added a comment.Tue, Jul 14, 11:52 PM

Change #1310679 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/crm@master] Add triggers from relationship table to set contact modified_date

https://gerrit.wikimedia.org/r/1310679

gerritbot added a project: Patch-For-Review.Tue, Jul 14, 11:52 PM
Lars claimed this task.Tue, Jul 14, 11:53 PM
Lars moved this task from Backlog to Doing on the Fundraising Sprint: Mediocre Ikea Kit board.
Lars added a subscriber: Eileenmcnaughton.

@Eileenmcnaughton We discussed adding a modified_date update on changes to the relationship table. I don't think this would actually make sense upstream. The existing triggers now in core are just on email, phone, address, IM and website, plus custom fields, not on contributions, recurs, activities, etc. The activity ones I saw are actually case related and all the others are our own (though mostly we rely on wmf_donor). So I think I'll just make the change for us.

gerritbot added a comment.Wed, Jul 15, 12:14 AM

Change #1310681 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/tools@master] Add has_daf_id to Acoustic export

https://gerrit.wikimedia.org/r/1310681

gerritbot added a comment.Wed, Jul 15, 1:13 AM

Change #1310679 merged by Eileen:

[wikimedia/fundraising/crm@master] Add triggers from relationship table to set contact modified_date

https://gerrit.wikimedia.org/r/1310679

Lars moved this task from Doing to Ready for Review on the Fundraising Sprint: Mediocre Ikea Kit board.Wed, Jul 15, 2:27 AM
gerritbot added a comment.Wed, Jul 15, 11:50 PM

Change #1310681 merged by jenkins-bot:

[wikimedia/fundraising/tools@master] Add daf_contact_id to Acoustic export

https://gerrit.wikimedia.org/r/1310681

Maintenance_bot removed a project: Patch-For-Review.Thu, Jul 16, 12:30 AM
Eileenmcnaughton moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: Mediocre Ikea Kit board.Thu, Jul 16, 3:49 AM
AKanji-WMF moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Mon, Jul 20, 8:00 PM
Lars edited projects, added: Fundraising Sprint: Notorious B.E.D.; removed: Fundraising Sprint: Mediocre Ikea Kit.Tue, Aug 4, 4:52 PM
Lars moved this task from Backlog to Done on the Fundraising Sprint: Notorious B.E.D. board.
Lars moved this task from Done to Doing on the Fundraising Sprint: Notorious B.E.D. board.Wed, Aug 5, 7:01 PM

Turns out we also have DAFs that are the same contact as the individual donor (when do DAF name is provided, we just put the DAF donation on the individual), so we'll need to also include those in this new field. These are about half of the total DAF donations (Gift Type = Donor Advised Fund). We also have ~400 DAF org contacts who have soft credits to individuals but no relationship, investigating this.

Lars added a comment.Wed, Aug 5, 7:25 PM

Turns out most of those 400 are Anonymous, there are only a handful from the last year that are missing relationships, so I think this is ignorable.

Lars moved this task from Doing to Ready for Review on the Fundraising Sprint: Notorious B.E.D. board.Wed, Aug 5, 8:44 PM
gerritbot added a comment.Wed, Aug 5, 8:45 PM

Change #1321630 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/tools@master] Also fill daf_contact_id with the contact's own id when they have a DAF gift

https://gerrit.wikimedia.org/r/1321630

gerritbot added a project: Patch-For-Review.Wed, Aug 5, 8:45 PM
Lars renamed this task from Add has_daf_id to Acoustic export to Add daf_contact_id to Acoustic export.Wed, Aug 5, 8:46 PM
Lars moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: Notorious B.E.D. board.Thu, Aug 6, 3:04 AM
Lars triaged this task as High priority.Thu, Aug 6, 7:50 PM
Lars moved this task from Backlog to Features on the FR-MGFE board.
AKanji-WMF added a project: fr-current-sprint.Mon, Aug 10, 6:15 PM
gerritbot added a comment.Mon, Aug 10, 10:41 PM

Change #1321630 merged by Eileen:

[wikimedia/fundraising/tools@master] Also fill daf_contact_id with the contact's own id when they have a DAF gift

https://gerrit.wikimedia.org/r/1321630

Maintenance_bot removed a project: Patch-For-Review.Mon, Aug 10, 11:31 PM
AKanji-WMF edited projects, added: Fundraising Sprint: Ottoman-o-war; removed: Fundraising Sprint: Notorious B.E.D..Tue, Aug 11, 9:10 PM
AKanji-WMF moved this task from Backlog to Pending Deployment on the Fundraising Sprint: Ottoman-o-war board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits