Page MenuHomePhabricator

clicking a suggested username after partial name entry on Mentor dashboard gives 'No mentees found'
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

I suspect a possible mismatch in filtering the dropdown list of suggested username matches on partial name entry, and the filter used to produce the results of the search when a complete username is given.

Steps to replicate the issue (include links if applicable):

  • Logon as me, or simulate viewing my Mentor dashboard
  • Go to p. 2 of the dashboard (don't know if this is required; that's just where I happened to be when I noticed the problem)
  • Start typing 'Laura'
  • after typing 'L-a-u', you should see three suggested usernames in the dropdown
  • click the top one, which starts, 'Laura'; (full username not given here for privacy; it is six words and 23 chars long; email me if you need it, or just check my mentees)

What happens?:

  • the dashboard is replaced by the message, 'No mentees found. \n Change your filters to find mentees.' (my filters: min=1 max=500; User:Laura... has 1 edit, but not in mainspace)

What should have happened instead?:

  • the dashboard should have shown the full username of the 'Laura...' user suggested in the dropdown. along with the dashboard row corresponding to that mentee

One thing occurs to me: are you filtering the dropdown suggestions using the same filter that you apply to the username search? If so, suppose I set minimum edits to 500, and search for some mentee names. Will the dropdown return any suggested usernames? It should not, because afaik, no mentee of mine has reached 500 edits yet.

If you are not using the same filter for the dropdown as for search, then that might be part of the explanation. But not in this 'Laura' example, unless you are also applying the min value to mainspace only; are you? If not, then the problem must lie elsewhere.

Event Timeline

Mathglot updated the task description. (Show Details)
Etonkovidova added subscribers: Urbanecm, Etonkovidova.

Thank you @Mathglot for filing the issue and for all the details!
Confirmed on `enwiki beta. The details are below:

pinging @Urbanecm

  • a mentor ET13 has many mentees on MentorDashboardd (several pages)
  • many mentees names start with 'User-' due to the beta cluster automation tests
  • on the first page enter 'User-0.35' - a user name that it's not displayed on the first page
  • the list of suggestions displays several options - select the first one 'User-0.3517593010048765-Iñtërnâtiônàlizætiøn'
  • discard the searched item and go to the second page and enter the same search term - 'User-0.35'
  • the same list of suggestions is displayed - select the first one. It'd be exactly the same user as was selected before
  • the page woud display - "No mentees found"

The gif shows the steps described above:

mentee_search.gif (809×890 px, 356 KB)

This is happening because filtering by the name doesn't reset the selected page (the mentee overview module is still in "give me 2nd page of results"). However, filtering by name lowers the number of available results drastically, meaning the second page of results is empty, hence the erroneous "no results found".

Change #1311574 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MenteeOverview: Reset page when selecting a username suggestion

https://gerrit.wikimedia.org/r/1311574

Change #1311575 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] tests: Tighten MenteeOverview filter page-reset assertion

https://gerrit.wikimedia.org/r/1311575

Change #1311576 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] tests: Extract store/mount helpers in MenteeOverview tests

https://gerrit.wikimedia.org/r/1311576

Urbanecm_WMF triaged this task as Low priority.
Urbanecm_WMF set the point value for this task to 1.

Change #1311574 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MenteeOverview: Reset page when selecting a username suggestion

https://gerrit.wikimedia.org/r/1311574

Change #1311575 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: Tighten MenteeOverview filter page-reset assertion

https://gerrit.wikimedia.org/r/1311575

Change #1311576 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: Extract store/mount helpers in MenteeOverview tests

https://gerrit.wikimedia.org/r/1311576

@Mathglot will you test this in Beta and confirm that it's working. I know this week is Wikimania so it's okay if this happens next week

@DMburugu, just wanted to give you an update that I won't be able to complete this right away. I was unfamiliar with Beta, but successfully created an account there. However, after copying over my en-wiki user page to my beta user page and saving it, I was given a site-wide block for having an external link on the page. I assume that can be dealt with in due course (after I figure out where to ask).

I'm willing to retest on beta once the block is settled, but I have a lot of questions about how to go about it. At first blush it didn't look like I am a mentor there, so how would I test it even if I weren't blocked? It takes some time to accumulate randomly assigned sufficient mentees to fill two dashboard pages, and where would they even come from? Or would I have to sign up as a claim-only mentor, and then claim a few dozen users?

I get your testing concern there. It feels like this would be easier to test in production, so we'll wait until the change is available later week.

@Mathglot - I verified the fix on enwiki beta - filtering works as expected now; if a user is prenet on Mentor dashboard, a user will be found via entering a user name on any pages.

The fix is now in production, so you can check it there. I don't have test mentors with many mentees in production, so it'd be valuable if you can verify that all works as expected now.
I keep this task open for now, waiting for your feedback.

I keep this task open for now, waiting for your feedback.

The 'Laura' example works now, thank you! (That's less than the complete regression test that I would prefer, but it's was the only test case I was aware of, and it's working now, so I think that's very indicative.)

Closing since Elena has confirmed. Any issues to be filled in a follow up