Page MenuHomePhabricator

Disabling suggestions in VE when the editor comes from Article Guidance
Closed, ResolvedPublic2 Estimated Story Points

Description

Disable Suggestion Mode in VE when editor arrives from Article Guidance

Context:

When a user completes the Article Guidance (AG) flow and enters the Visual Editor, Suggestion Mode triggers incorrectly on the AG-provided article structure (outline skeleton). This content is a starting point placed by AG, not content written by the editor, Suggestion Mode should not fire on it.

Solution:

Use target.editcheckController.suppressSuggestionDisplay( true ) in a simple JS module on the AG side, called when transitioning the user from AG into VE.

This API was built for this purpose (used by the Growth team to control suggestion display). It is more stable than the ecenable URL parameter, which is a dev-only debug flag with no stability guarantees.

References:

Event Timeline

Change #1311096 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ArticleGuidance@master] Suppress VE suggestions when editing from Article Guidance

https://gerrit.wikimedia.org/r/1311096

Change #1311096 merged by jenkins-bot:

[mediawiki/extensions/ArticleGuidance@master] Suppress VE suggestions when editing from Article Guidance

https://gerrit.wikimedia.org/r/1311096