Page MenuHomePhabricator

[Traffic limit exception] Traffic limit exception UI is available only for growthbook-admin LDAP group
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

We agreed on that the new UI where traffic limit exceptions will be managed will be only available for users than belong to growthbook-admin LDAP group.

The current login mechanism doesn't require any specific role (belonging to wmf would be enough) but user groups are being fetched when an user logs in (see routes/login.js and frontend/src/components/modals/Login.vue). Now Test Kitchen UI will have to use that information to check whether the current user belongs to the corresponding LDAP group to grant access to the traffic limit exception UI.

Also, we will need something similar to how some existing endpoints requires authentication (see routes/instruments.js, for example), that is provided by util/auth.js#isAuth, where we only check that the user is logged in. In this case I guess we would need an additional function where also the exact role is checked.

Acceptance criteria

  • The new UI to manage traffic limit exception is only available for users than belong to growthbook-admin LDAP group
  • The endpoints that manage traffic limit exceptions require authentication where growthbook-admin role is checked

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Restrict the traffic limit exception UI to the growthbook-admin grouprepos/data-engineering/test-kitchen!374cjmingT432310/access-traffic-limit-exception-uimain
Customize query in GitLab

Event Timeline

KReid-WMF set the point value for this task to 2.

Change #1319178 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] Test Kitchen UI: Deploy v1.5.0 release to staging

https://gerrit.wikimedia.org/r/1319178

Change #1319178 merged by jenkins-bot:

[operations/deployment-charts@master] Test Kitchen UI: Deploy v1.5.0 release to staging

https://gerrit.wikimedia.org/r/1319178

Change #1321827 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] Test Kitchen UI: Deploy v1.5.2 release to production

https://gerrit.wikimedia.org/r/1321827

Change #1321827 merged by jenkins-bot:

[operations/deployment-charts@master] Test Kitchen UI: Deploy v1.5.2 release to production

https://gerrit.wikimedia.org/r/1321827