Completion widgets can contain a flicker of past results when reopening
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DLynch
	Thu, Jul 16, 9:28 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

DLynch

Description

Steps to replicate the issue:

Use an autocomplete widget (\ or @)
Find something
Close the widget, then open another instance of the widget

What happens?:
There can be a momentary flicker of the previous invocation's results, particularly if getSuggestions is slow and async

What should have happened instead?:
Initially empty menu every time

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	ui.CompletionWidget: avoid flicker of previous results on reopen	DLynch	VisualEditor/VisualEditor	master	+4 -0
	Update VE core submodule to master (64f0786ec)	Esanders	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T432400: Enable completion of links, templates, tags, and magic words in VisualEditor source modes

Event Timeline

DLynch created this task.Thu, Jul 16, 9:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Jul 16, 9:28 PM

Change #1311569 had a related patch set uploaded (by DLynch; author: DLynch):

[VisualEditor/VisualEditor@master] ui.CompletionWidget: avoid flicker of previous results on reopen

https://gerrit.wikimedia.org/r/1311569

gerritbot added a project: Patch-For-Review.Thu, Jul 16, 9:29 PM

DLynch claimed this task.Thu, Jul 16, 9:30 PM

DLynch edited projects, added: Editing-team (FY2026-27 Q1 sprint 1); removed: Editing-team.

DLynch moved this task from Decision to be made to Code review on the Editing-team (FY2026-27 Q1 sprint 1) board.

Test wiki created on Patch demo by DLynch (WMF) using patch(es) linked to this task:
https://538d6868b8.catalyst.wmcloud.org/w/

Test wiki created on Patch demo by DLynch (WMF) using patch(es) linked to this task:
https://395d77c269.catalyst.wmcloud.org/w/

Test wiki on Patch demo by DLynch (WMF) using patch(es) linked to this task was deleted:

~~https://538d6868b8.catalyst.wmcloud.org/w/~~

Change #1311569 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] ui.CompletionWidget: avoid flicker of previous results on reopen

https://gerrit.wikimedia.org/r/1311569

Testing of this will effectively be rolled into feedback on T432400.

Maintenance_bot removed a project: Patch-For-Review.Fri, Jul 17, 9:31 PM

Change #1312555 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (64f0786ec)

https://gerrit.wikimedia.org/r/1312555

gerritbot added a project: Patch-For-Review.Mon, Jul 20, 4:21 PM

Change #1312555 merged by jenkins-bot: