Page MenuHomePhabricator
Create Task
Maniphest T432592

[jobs-api,jobs-cli] `toolforge jobs load` uses PATCH for one-off jobs too
Closed, ResolvedPublic
Actions

Description

Updating one-off jobs is currently disabled as they are not stored in storage, so instead we should either move them to storage (and change the flows for them) or on the cli call POST instead of PATCH for one-off jobs.

Related Objects

Event Timeline

dcaro created this task.Mon, Jul 20, 11:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Jul 20, 11:55 AM
Sebastian_Berlin-WMSE awarded a token.Mon, Jul 20, 12:00 PM
Sebastian_Berlin-WMSE mentioned this in T427907: Make declarations for Category:Images from Wiki Loves Earth 2022.
Sebastian_Berlin-WMSE subscribed.Mon, Jul 20, 12:33 PM
dcaro changed the task status from Open to In Progress.Mon, Jul 20, 1:17 PM
dcaro claimed this task.
dcaro triaged this task as High priority.
dcaro moved this task from Backlog to In review on the tools-platform-team board.
Danysan1 subscribed.Tue, Jul 21, 10:34 AM

I'm trying to use this jobs.yaml file to start the one-off job defined in that file but I'm getting the following error:

tools.wikidata-geo-dumps@tools-bastion-15:~/wikidata-geo-dumps/toolforge$ toolforge jobs list
+-----------------------------+-------------------+------------------------------------------+
|          Job name:          |     Job type:     |                 Status:                  |
+-----------------------------+-------------------+------------------------------------------+
| wikidata-geo-dumps-generate | scheduled: @daily | Last schedule time: 2026-07-20T11:50:00Z |
+-----------------------------+-------------------+------------------------------------------+
tools.wikidata-geo-dumps@tools-bastion-15:~/wikidata-geo-dumps/toolforge$ toolforge-jobs load jobs.yaml
INFO: loading job 'wikidata-geo-dumps-generate'...
Job wikidata-geo-dumps-generate is already up to date
INFO: loading job 'wikidata-geo-dumps-test'...
OneOffJobs can't be updated, delete and recreate it instead
INFO: 2 job(s) loaded successfully
tools.wikidata-geo-dumps@tools-bastion-15:~/wikidata-geo-dumps/toolforge$ toolforge jobs delete wikidata-geo-dumps-test
ERROR: Job 'wikidata-geo-dumps-test' does not exist

So the list and delete commands are saying that the job 'wikidata-geo-dumps-test' does not exist but despite that load is returning an error OneOffJobs can't be updated, delete and recreate it instead as if the job already existed, which is incosistent.
Is this bug caused by the object of this task? Or should I open another task?

DamianZaremba subscribed.Tue, Jul 21, 12:24 PM
In T432592#12140722, @Danysan1 wrote:

That is exactly the bug this task covers.

You can execute a toolforge jobs run passing the same options that are in the yaml to create the job in the meantime.

Danysan1 awarded a token.Tue, Jul 21, 9:55 PM
CodeReviewBot added a project: Patch-For-Review.Thu, Jul 23, 11:33 AM

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/164

d/changelog: bump to 16.1.31

CodeReviewBot added a comment.Thu, Jul 23, 12:59 PM

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/164

d/changelog: bump to 16.1.31

dcaro closed this task as Resolved.Thu, Jul 23, 1:02 PM
dcaro moved this task from In review to Done on the tools-platform-team board.

Done!

Maintenance_bot removed a project: Patch-For-Review.Thu, Jul 23, 1:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits