Background
For codex Menus or Selects, if the individual menu items are links with urls specified, the padding is not factored into their click target, making it possible for you to select the option by clicking around the edge of the menu item rather than triggering the link
pointer is not visible, but note the difference in hover states
This can be reproduced on the Codex MenuItem page, either by inspecting the element or observing the clickable surface of the item
User story
As a user, I don't want to accidentally misclick and select an item in a list without it properly linking me to a separate page
Design requirements
Add design requirements or link to design files.
Requirements
Acceptance criteria
- For MenuItems with URLs, clicking anywhere in the entire MenuItem, including padding, will take you to the link
- MenuItems without URLs are unaffected
- All MenuItems have the same padding and appearance as before
QA strategy
- Risky change? Potentially high risk due to impacting all MenuItems - potentially lower risk if the change can be scoped to only those with url specified
- QA by: QS, PM, and engineering
- QA in: Any/all
- Test steps: Inspect the element, hover over the a tag and observe that it doesn't look like this
or if it does, that the surface outside the smaller box is still clickable
Communication criteria
Unclear if this should be announced in any way since it's a Codex change
Rollback plan
I would expect this to all be accomplished using JS and CSS, so should be easy to revert if broken