Page MenuHomePhabricator

Consider removing cable IDs from interface descriptions
Closed, ResolvedPublic

Description

We currently add the cable ID in interface descriptions when they are defined in Netbox.

This comes from a time where we didn't have Netbox to document cable IDs, so the interface description was the source of truth.

It now feels like it's cluttering the interface descriptions for no good reason anymore, it also created outstanding diffs when someone updates a cable ID but forget to run Homer.

What do people think of removing them ?

Event Timeline

ayounsi triaged this task as Low priority.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Yeah I think this makes sense. It's not so often we have to check the cable label that it's much hassle to look it up in Netbox.

It might make us less aware of "temporary" labels that haven't been changed but I'm not sure that's a good enough reason to keep them there so +1

Change #1313174 had a related patch set uploaded (by Ayounsi; author: Ayounsi):

[operations/software/homer/deploy@master] Remove cable label from interfaces descriptions

https://gerrit.wikimedia.org/r/1313174

Change #1313177 had a related patch set uploaded (by Ayounsi; author: Ayounsi):

[operations/software/homer@master] Don't fetch the cable label

https://gerrit.wikimedia.org/r/1313177

Change #1313174 merged by Ayounsi:

[operations/software/homer/deploy@master] Remove cable label from interfaces descriptions

https://gerrit.wikimedia.org/r/1313174

Merged and deploying it. It's going to take a bit of time as it means a different diff per device.

ayounsi claimed this task.

Change #1313177 merged by jenkins-bot:

[operations/software/homer@master] Don't fetch the cable label

https://gerrit.wikimedia.org/r/1313177

Change #1319841 had a related patch set uploaded (by Ayounsi; author: Ayounsi):

[operations/cookbooks@master] junos_set_interface_config: remove cable ID from description

https://gerrit.wikimedia.org/r/1319841

Change #1319841 merged by jenkins-bot:

[operations/cookbooks@master] junos_set_interface_config: remove cable ID from description

https://gerrit.wikimedia.org/r/1319841