Hoarde currently associates a LambdaRequest specifically with a request for a wiki/page/revision based artifact.
We should name the artifact type protocols explicitly asap, so that users don't have to migrate later if we add support for other kinds of artifacts (e.g. users).
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| (more) explicit struct and rpc naming | repos/sre/hoarde!12 | eevans | explicit_naming | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Eevans | T414140 Linked Artifact Cache — MVP | |||
| Resolved | Eevans | T432732 Linked Artifact Cache - use explicit names in gRPC protocol |
This patch is copying Hoarde's lambda.proto file. If that patch is deployed, it will make it difficult to change the protobuf contract later. cc @Esanders
LambdaResponse is relatively generic and is probably fine as is.
Perhaps:
?
Related:
eevans opened https://gitlab.wikimedia.org/repos/sre/hoarde/-/merge_requests/12
(more) explicit struct and rpc naming
eevans merged https://gitlab.wikimedia.org/repos/sre/hoarde/-/merge_requests/12
(more) explicit struct and rpc naming
Change #1314000 had a related patch set uploaded (by Eevans; author: Eevans):
[operations/deployment-charts@master] linked-artifacts: upgrade to Hoarde v1.5.0
Change #1314000 merged by jenkins-bot:
[operations/deployment-charts@master] linked-artifacts: upgrade to Hoarde v1.5.0
Change #1314013 had a related patch set uploaded (by Eevans; author: Eevans):
[operations/deployment-charts@master] linked-artifacts: upgrade (production) to Hoarde v1.5.0
Change #1314013 merged by jenkins-bot:
[operations/deployment-charts@master] linked-artifacts: upgrade (production) to Hoarde v1.5.0