Page MenuHomePhabricator
Create Task
Maniphest T432798

REST API vNext: Wire standard error shape into REST framework as the default, and apply it to one vNext module
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Goals:

  • Update the REST framework's default error formatter to emit the shape finalized in T432797.
  • Implement tests with placeholder vNext module
  • Make the pattern repeatable: document it (or add scaffolding/defaults) so authors of *new* vNext modules get the standard error format without bespoke work per module.

Starting point: Router::getResponseFactory( $info ) already exists as a per-module construction seam (see T432795) but currently ignores $info -- this is where T432795 decision gets implemented.

BLOCKERS:

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
REST: consolidate error formatter constructionDaniel Kinzlermediawiki/coremaster+160 -127
wmf-config: Register content/v2-beta REST module as disabledAghirellioperations/mediawiki-configmaster+1 -1
REST: Create the ResponseFactory per requestDaniel Kinzlermediawiki/coremaster+210 -100
REST: Decouple JsonLocalizer from ResponseFactoryDaniel Kinzlermediawiki/coremaster+214 -194
Tests: remove ResponseFactory injection from REST handler test.Daniel Kinzlermediawiki/extensions/CheckUsermaster+2 -15
Tests: Inject fake Module into REST HandlerDaniel Kinzlermediawiki/extensions/CheckUsermaster+19 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

AGhirelli-WMF created this task.Jul 21 2026, 11:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2026, 11:15 PM
AGhirelli-WMF added parent tasks: T432797: REST API vNext: [SPIKE] Finalize standard error response shape for vNext REST modules, T432794: Epic: REST API vNext Beta Module > Shared Error Responses (PP3.5.2 26/27).Jul 21 2026, 11:15 PM
AGhirelli-WMF edited parent tasks, added: T432868: REST API vNext: Error handling refactoring; removed: T432794: Epic: REST API vNext Beta Module > Shared Error Responses (PP3.5.2 26/27).Jul 22 2026, 2:25 PM
HCoplin-WMF updated the task description. (Show Details)Jul 22 2026, 2:25 PM
HCoplin-WMF updated the task description. (Show Details)
HCoplin-WMF updated the task description. (Show Details)Jul 22 2026, 2:28 PM
HCoplin-WMF moved this task from Incoming (Needs Triage) to Needs Further Discussion on the MediaWiki-API-Platform-Team board.Jul 22 2026, 2:31 PM
AGhirelli-WMF added a parent task: T432870: REST API vNext: create a beta vNext module.Jul 22 2026, 2:32 PM
HCoplin-WMF moved this task from Needs Further Discussion to To Refine on the MediaWiki-API-Platform-Team board.Jul 22 2026, 2:34 PM
HCoplin-WMF moved this task from To Refine to Needs Further Discussion on the MediaWiki-API-Platform-Team board.
KineticPelagic subscribed.Aug 5 2026, 5:40 AM
AGhirelli-WMF mentioned this in T432795: REST API vNext: [SPIKE] Error format versioning — explicit declaration vs. schema-derived.Aug 13 2026, 10:23 PM
AGhirelli-WMF mentioned this in T432797: REST API vNext: [SPIKE] Finalize standard error response shape for vNext REST modules.Aug 18 2026, 1:57 PM
AGhirelli-WMF mentioned this in T435626: Remove $textFormatters from ResponseFactory's constructor.Aug 21 2026, 3:01 PM
AGhirelli-WMF claimed this task.Aug 25 2026, 2:56 PM
AGhirelli-WMF triaged this task as High priority.
AGhirelli-WMF edited projects, added: MediaWiki-API-Platform-Team (MediaWiki-Interfaces-Sprints); removed: MediaWiki-API-Platform-Team.
AGhirelli-WMF changed the task status from Open to In Progress.Aug 26 2026, 10:45 AM
AGhirelli-WMF moved this task from Committed to In Progress on the MediaWiki-API-Platform-Team (MediaWiki-Interfaces-Sprints) board.
AGhirelli-WMF set the point value for this task to 3.Aug 27 2026, 5:42 PM
AGhirelli-WMF moved this task from In Progress to Code Review on the MediaWiki-API-Platform-Team (MediaWiki-Interfaces-Sprints) board.Sep 2 2026, 5:20 PM
gerritbot added a comment.Sep 8 2026, 8:57 AM

Change #1335900 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] REST: Create the ResponseFactory per request

https://gerrit.wikimedia.org/r/1335900

gerritbot added a project: Patch-For-Review.Sep 8 2026, 8:57 AM
gerritbot added a comment.Sep 8 2026, 9:00 AM

Change #1337858 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] REST: Decouple JsonLocalizer from ResponseFactory

https://gerrit.wikimedia.org/r/1337858

gerritbot added a comment.Sep 8 2026, 9:52 AM

Change #1337871 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/extensions/CheckUser@master] Tests: Inject fake Module into REST Handler

https://gerrit.wikimedia.org/r/1337871

gerritbot added a comment.Sep 8 2026, 9:56 AM

Change #1337872 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/extensions/CheckUser@master] Tests: remove ResponseFactory injection from REST handler test.

https://gerrit.wikimedia.org/r/1337872

gerritbot added a comment.Sep 11 2026, 3:15 PM

Change #1339790 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] REST: consolidate error formatter construction

https://gerrit.wikimedia.org/r/1339790

gerritbot added a comment.Sep 11 2026, 3:58 PM

Change #1339811 had a related patch set uploaded (by Aghirelli; author: Aghirelli):

[operations/mediawiki-config@master] wmf-config: Register content/v2-beta REST module as disabled

https://gerrit.wikimedia.org/r/1339811

gerritbot added a comment.Mon, Sep 14, 4:36 PM

Change #1337871 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Tests: Inject fake Module into REST Handler

https://gerrit.wikimedia.org/r/1337871

gerritbot added a comment.Mon, Sep 14, 4:39 PM

Change #1337858 merged by jenkins-bot:

[mediawiki/core@master] REST: Decouple JsonLocalizer from ResponseFactory

https://gerrit.wikimedia.org/r/1337858

gerritbot added a comment.Mon, Sep 14, 4:40 PM

Change #1337872 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Tests: remove ResponseFactory injection from REST handler test.

https://gerrit.wikimedia.org/r/1337872

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.20; 2026-09-15).Mon, Sep 14, 5:00 PM
gerritbot added a comment.Mon, Sep 14, 5:34 PM

Change #1335900 merged by jenkins-bot:

[mediawiki/core@master] REST: Create the ResponseFactory per request

https://gerrit.wikimedia.org/r/1335900

gerritbot added a comment.Mon, Sep 14, 8:05 PM

Change #1339811 merged by jenkins-bot:

[operations/mediawiki-config@master] wmf-config: Register content/v2-beta REST module as disabled

https://gerrit.wikimedia.org/r/1339811

Stashbot mentioned this in T432849: [Milestone 1] Observability - Build tools, document and observe behavior and evolution of our multi-layer caching system.Mon, Sep 14, 8:06 PM

Mentioned in SAL (#wikimedia-operations) [2026-09-14T20:06:51Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1339811|wmf-config: Register content/v2-beta REST module as disabled (T432798)]], [[gerrit:1338274|wikifunctions: Move abstract fragments to mainstash (T432849)]]

Stashbot added a comment.Mon, Sep 14, 8:24 PM

Mentioned in SAL (#wikimedia-operations) [2026-09-14T20:24:18Z] <jforrester@deploy1003> jforrester, aghirelli: Backport for [[gerrit:1339811|wmf-config: Register content/v2-beta REST module as disabled (T432798)]], [[gerrit:1338274|wikifunctions: Move abstract fragments to mainstash (T432849)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Mon, Sep 14, 8:32 PM

Mentioned in SAL (#wikimedia-operations) [2026-09-14T20:32:12Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1339811|wmf-config: Register content/v2-beta REST module as disabled (T432798)]], [[gerrit:1338274|wikifunctions: Move abstract fragments to mainstash (T432849)]] (duration: 25m 21s)

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.21; 2026-09-22); removed: MW-1.47-notes (1.47.0-wmf.20; 2026-09-15).Tue, Sep 15, 3:00 PM
AGhirelli-WMF closed this task as Resolved.Tue, Sep 15, 9:43 PM
AGhirelli-WMF moved this task from Code Review to Demo Ready! on the MediaWiki-API-Platform-Team (MediaWiki-Interfaces-Sprints) board.
AGhirelli-WMF mentioned this in T438746: REST API vNext: OpenAPI error response spec doesn't reflect module's errorSchemaVersion.Mon, Sep 21, 2:35 PM
gerritbot added a comment.Mon, Sep 21, 7:17 PM

Change #1339790 merged by jenkins-bot:

[mediawiki/core@master] REST: consolidate error formatter construction

https://gerrit.wikimedia.org/r/1339790

Maintenance_bot removed a project: Patch-For-Review.Mon, Sep 21, 7:31 PM
KineticPelagic edited projects, added: MediaWiki-API-Platform-Team; removed: MediaWiki-API-Platform-Team (MediaWiki-Interfaces-Sprints).Wed, Oct 7, 1:48 AM
KineticPelagic moved this task from MediaWiki-Interfaces-Sprints to Done on the MediaWiki-API-Platform-Team board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits