Page MenuHomePhabricator
Create Task
Maniphest T432869

Detect fragment destination when making a request via OrchestratorRequest
Open, In Progress, Needs TriagePublic
Actions

Description

Description

OrchestratorRequest must be able to distinguish whether a request is destined for an AW fragment or an embedded fragment (vs. to a test or a wikifunctions requested call), as a prerequisite for applying different caching strategies per request type.

Desired behavior/Acceptance criteria

  • OrchestratorRequest exposes a way to identify the fragment destination (AW vs. embedded)
  • Only calls coming from AbstractWikiRequest can be recognized as such at the OrchestratorRequest side (e.g. this cannot be faked via other interfaces)
  • Only calls coming from WikifunctionsClientRequestJob can be recognized as such at the OrchestratorRequest side (e.g. this cannot be faked via other interfaces)

Completion checklist

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Set origin header on wikilambda_function_call and propagate to OrchestratorRequestGenoveva Galarzamediawiki/extensions/WikiLambdamaster+161 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Wed, Jul 22, 2:24 PM
gengh added a parent task: T432867: [Milestone 3] Development - Build the new durable storage layer for Wikifunctions and Abstract Wikipedia fragments.
gengh edited projects, added: Abstract Wikipedia team (27Q1 (Jul–Sep)); removed: Abstract Wikipedia team.Wed, Jul 22, 3:09 PM
gengh claimed this task.Mon, Aug 3, 1:27 PM
Jdforrester-WMF changed the task status from Open to In Progress.Tue, Aug 4, 1:13 PM
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.
Jdforrester-WMF subscribed.Tue, Aug 4, 4:20 PM

In chatting about this, I said that locking down the API so that it can't be called from outside the cluster is very hard to achieve and it's easiest to just make it intentional, not impossible.

gerritbot added a comment.Wed, Aug 5, 7:04 PM

Change #1321621 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Set origin header on wikilambda_function_call and propagate to OrchestratorRequest

https://gerrit.wikimedia.org/r/1321621

gerritbot added a project: Patch-For-Review.Wed, Aug 5, 7:04 PM
gengh moved this task from In Engineering to In Code review on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.Thu, Aug 6, 8:17 AM
gerritbot added a comment.Thu, Aug 6, 4:40 PM

Change #1321621 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Set origin header on wikilambda_function_call and propagate to OrchestratorRequest

https://gerrit.wikimedia.org/r/1321621

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.Thu, Aug 6, 4:49 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.15; 2026-08-11).Thu, Aug 6, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Thu, Aug 6, 5:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits