Page MenuHomePhabricator

Build Jump to article link for ABCDE test
Closed, ResolvedPublic1 Estimated Story Points

Assigned To
Authored By
KSarabia-WMF
Jul 22 2026, 4:14 PM
Referenced Files
F101837323: IMG_9005 (1).PNG
Fri, Sep 4, 10:45 PM
F101837382: IMG_9004.PNG
Fri, Sep 4, 10:45 PM
F101837366: IMG_9007.PNG
Fri, Sep 4, 10:45 PM
F101837358: IMG_9006.PNG
Fri, Sep 4, 10:45 PM
F101837092: Screenshot_20260904-151309_Chrome.jpg
Fri, Sep 4, 10:45 PM
F101837106: Screenshot_20260904-151319_Chrome.jpg
Fri, Sep 4, 10:45 PM
F101837090: Screenshot_20260904-151249_Chrome.jpg
Fri, Sep 4, 10:45 PM
F101837087: Screenshot_20260904-151229_Chrome.jpg
Fri, Sep 4, 10:45 PM

Description

Pre-requisite for T431362: Image Carousel A/B/C/D/E retest

Please refer to T430688 for Spike Results

Success Criteria TK

Designs: figma | prototype

Details

Other Assignee
Etonkovidova
Related Changes in Gerrit:

Event Timeline

KSarabia-WMF renamed this task from Jump to article to Build Jump to article link for ABCDE test.Jul 22 2026, 4:15 PM
KSarabia-WMF updated the task description. (Show Details)
HSwan-WMF set the point value for this task to 5.Jul 28 2026, 4:51 PM
HSwan-WMF moved this task from Incoming/Inbox to Needs Refinement on the Reader Growth Team board.
HSwan-WMF moved this task from Needs Refinement to Ready on the Reader Growth Team board.
etz removed etz as the assignee of this task.
etz subscribed.

Change #1328710 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/MultimediaViewer@master] Introduce carousel dialog

https://gerrit.wikimedia.org/r/1328710

Change #1328710 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Introduce carousel dialog

https://gerrit.wikimedia.org/r/1328710

lwatson changed the point value for this task from 5 to 1.Tue, Sep 1, 5:53 PM

Repointing to 1pt because the implementation was completed in the prior sprint. We carried this task over to the current sprint to complete code review and QA.

Assigning Elena for QA

Tested on enwiki beta; the screenshots are for https://en.wikipedia.beta.wmcloud.org/wiki/Triton_(moon). The functionality - the controls on an image card - work as expected, no issues found.
Note: Prototype and figma design do not provide the realistic position of image cards, so the screenshots show the current state of imgg cards; probably need @JScherer-WMF review.

Two things to review:

  • the height of an img card is dfferent for landscape and portrait oriented images
  • some portrait-oriented images differ in height
real Android Samsung Galaxy (CSS design viewport 360px)real device iPhone 11 (CSS design viewport 414px)
Screenshot_20260904-151229_Chrome.jpg (1,080×2,220 px, 463 KB)
Screenshot_20260904-151249_Chrome.jpg (1,080×2,220 px, 381 KB)
Screenshot_20260904-151319_Chrome.jpg (1,080×2,220 px, 565 KB)
Screenshot_20260904-151309_Chrome.jpg (1,080×2,220 px, 326 KB)
IMG_9006.PNG (296×640 px, 465 KB)
IMG_9007.PNG (296×640 px, 309 KB)
IMG_9004.PNG (296×640 px, 395 KB)
IMG_9005 (1).PNG (828×1,792 px, 340 KB)

The height is variable, and depends on the image size (the height corresponding to full-width) and length of the caption (which iirc maxes out at 5 lines). If the height can’t fit on the screen, we won’t crop the image but shrink it until it all fits.

The height is variable, and depends on the image size (the height corresponding to full-width) and length of the caption (which iirc maxes out at 5 lines). If the height can’t fit on the screen, we won’t crop the image but shrink it until it all fits.

This is correct. The size is meant to respond to the size of the image being shown.