Description
Details
- Other Assignee
- Etonkovidova
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Introduce carousel dialog | Matthias Mullie | mediawiki/extensions/MultimediaViewer | master | +730 -116 |
Related Objects
Event Timeline
Change #1328710 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Introduce carousel dialog
Change #1328710 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Introduce carousel dialog
Repointing to 1pt because the implementation was completed in the prior sprint. We carried this task over to the current sprint to complete code review and QA.
Tested on enwiki beta; the screenshots are for https://en.wikipedia.beta.wmcloud.org/wiki/Triton_(moon). The functionality - the controls on an image card - work as expected, no issues found.
Note: Prototype and figma design do not provide the realistic position of image cards, so the screenshots show the current state of imgg cards; probably need @JScherer-WMF review.
Two things to review:
- the height of an img card is dfferent for landscape and portrait oriented images
- some portrait-oriented images differ in height
| real Android Samsung Galaxy (CSS design viewport 360px) | real device iPhone 11 (CSS design viewport 414px) |
|---|---|
The height is variable, and depends on the image size (the height corresponding to full-width) and length of the caption (which iirc maxes out at 5 lines). If the height can’t fit on the screen, we won’t crop the image but shrink it until it all fits.



