Given that we've seen 'normal' user accounts created which seem to be used by non-humans only in https://phabricator.wikimedia.org/maniphest/?ids=410571,418140,329748,331529,407690,429308#R , we should make users more aware that bot accounts exist.
Ideally by extending an existing string in that form via translation.override in https://gitlab.wikimedia.org/repos/phabricator/deployment/-/blob/wmf/stable/scap/templates/phabricator/conf/local/local.json.j2
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Inform about Bot accounts on user account creation form | repos/phabricator/phabricator!124 | aklapper | aklapper-T432888 | wmf/stable |
Cannot find a string or hook, so I guess it's another downstream change:
diff --git a/src/applications/auth/controller/PhabricatorAuthRegisterController.php b/src/applications/auth/controller/PhabricatorAuthRegisterController.php index 5919af27e4..461d048d2e 100644 --- a/src/applications/auth/controller/PhabricatorAuthRegisterController.php +++ b/src/applications/auth/controller/PhabricatorAuthRegisterController.php @@ -507,8 +507,19 @@ final class PhabricatorAuthRegisterController unset($unguarded); } + // WMF T432888 - avoid normal accounts used for bots activity + $bot_account_hint = null; + if ($provider->getProviderName() === 'MediaWiki') { + $bot_account_hint = pht( + 'NOTE: If this account will be used for automated activity, then you '. + 'must follow [[ %s | the Bot Account creation process ]] instead.', + 'https://www.mediawiki.org/wiki/Phabricator/Bots'); + } + $form = id(new AphrontFormView()) ->setUser($request->getUser()) + // WMF T432888 - avoid normal accounts used for bots activity + ->appendRemarkupInstructions($bot_account_hint) ->addHiddenInput('phase', 2); if (!$is_default) {
aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/124
Inform about Bot accounts on user account creation form
aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/124
Inform about Bot accounts on user account creation form