Page MenuHomePhabricator

Allow authorized users to add or remove the false positive tag
Closed, ResolvedPublic

Description

Summary

We need a way for users with the rights to view the T431295: Define a change tag for "likely contains personal information" tag, to be able to add T431287: Define a "false positive (personal information)" private change tag to revisions.

Notes

  • We likely want a REST API endpoint gated to users with the relevant right
  • We should ensure that the false positive tag can only be applied to revisions that have the "Likely contains personal information" change tag
  • We probably also want a way to undo this addition of the tag
  • This task could also consider a simple JS widget that will allow for adding or removing the false positive tag, visible on ?action=history, Special:Log, and diff views
NOTE: We should likely not use the existing tag editing features for this, because we want to gate the addition of the tag on whether the "Likely contains personal information" tag already exists on the revision. Additionally, the existing tag editing mechanisms have not been updated for private change tags

Acceptance criteria

  • Users with rights to view the "Likely contains personal information" tag on a revision can apply the "False positive (personal information)" tag to that same revision

Related Objects

Event Timeline

Change #1318679 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/WikimediaAntiAbuse@master] Add REST API to mark revisions as false positives

https://gerrit.wikimedia.org/r/1318679

Change #1318679 merged by jenkins-bot:

[mediawiki/extensions/WikimediaAntiAbuse@master] Add REST API to mark revisions as false positives

https://gerrit.wikimedia.org/r/1318679

dom_walden subscribed.

I have tested marking and unmarking various revisions on my local wiki.

I have checked that users not in the suppressor group cannot add the tag and that you cannot add the tag to the revision of a page you are blocked from.

I notice that the only form of logging appears to be in the server logs, where you see something like:

[WikimediaAntiAbuse] Marked revision as false positive

There appears to already be a task to improve this T435925.