Page MenuHomePhabricator
Create Task
Maniphest T433013

Username completion widget header is illegible in dark mode
Closed, ResolvedPublic
Actions

Description

In DiscussionTools the username autocomplete header is hard to read in dark mode.

CleanShot 2026-07-23 at 15.29.45@2x.png (648×450 px, 37 KB)

This is because it has some hardcoded colors for the text, rather than using tokens.

These overrides also spill over into affecting the new completions for links and templates from T432400.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update VE core submodule to master (bb771ace0)DLynchmediawiki/extensions/VisualEditormaster+2 -1
CommentTargetWidget: use a token for the override of completion headersDLynchmediawiki/extensions/DiscussionToolsmaster+6 -6
CompletionWidget: color the header with a tokenDLynchVisualEditor/VisualEditormaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

DLynch created this task.Jul 23 2026, 8:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2026, 8:31 PM
gerritbot added a comment.Jul 23 2026, 8:34 PM

Change #1315033 had a related patch set uploaded (by DLynch; author: DLynch):

[VisualEditor/VisualEditor@master] CompletionWidget: color the header with a token

https://gerrit.wikimedia.org/r/1315033

gerritbot added a project: Patch-For-Review.Jul 23 2026, 8:34 PM

Change #1315034 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] CommentTargetWidget: use a token for the override of completion headers

https://gerrit.wikimedia.org/r/1315034

DLynch moved this task from Incoming to Code review on the Editing-team (FY2026-27 Q1 sprint 2) board.Jul 23 2026, 9:03 PM
gerritbot added a comment.Jul 23 2026, 9:35 PM

Change #1315033 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] CompletionWidget: color the header with a token

https://gerrit.wikimedia.org/r/1315033

gerritbot added a comment.Jul 23 2026, 9:37 PM

Change #1315094 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bb771ace0)

https://gerrit.wikimedia.org/r/1315094

gerritbot added a comment.Jul 23 2026, 10:38 PM

Change #1315094 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bb771ace0)

https://gerrit.wikimedia.org/r/1315094

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.13; 2026-07-28).Jul 23 2026, 11:00 PM
gerritbot added a comment.Jul 23 2026, 11:11 PM

Change #1315034 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentTargetWidget: use a token for the override of completion headers

https://gerrit.wikimedia.org/r/1315034

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2026, 11:30 PM
DLynch moved this task from Code review to QA on the Editing-team (FY2026-27 Q1 sprint 2) board.Jul 24 2026, 6:55 PM
DLynch added a project: Editing QA.
DLynch added a project: Essential-Work.Jul 24 2026, 9:51 PM
Hakimi97 subscribed.Jul 27 2026, 1:25 AM
EAkinloose edited projects, added: Verified; removed: Editing QA.EditedAug 3 2026, 11:39 PM
EAkinloose subscribed.

image.png (2,144×344 px, 30 KB)

image.png (2,462×186 px, 100 KB)

image.png (2,538×526 px, 348 KB)

EAkinloose attached a referenced file: F97093820: image.png. (Show Details)Aug 3 2026, 11:44 PM
EAkinloose closed this task as Resolved.Aug 3 2026, 11:48 PM
EAkinloose attached a referenced file: F97094280: image.png. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits