Change #1323040 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Add Employer field to form

https://gerrit.wikimedia.org/r/1323040

@AnnWF @Cstone I currently don't see the employer field in the donate->payment flow (e.g. here: https://payments.wikimedia.org/index.php?title=Special:GravyGateway&appeal=JimmyQuote&country=IT&currency=EUR&payment_method=cc&recurring=0&gateway=gravy&uselang=en&amount=10&opt_in=0&wmf_medium=spontaneous&wmf_campaign=spontaneous&wmf_source=fr-redir.default%7Edefault%7Edefault%7Edefault%7Econtrol.cc&wmf_key=vw_1728%7Evh_873%7EotherAmt_0%7EvalidateError_1%7Etime_46)

Could you please show me where or how is currently visible to donors?

@Laurabarluzzi This is a field who's visibility we control with config. I think right now it's only available in the US. Each payment processor has a country_fields.yaml which controls the visibility of the fields per country

@Cstone thanks, now it's clear. Should we then isolate this employer field to US even in ComboWiki? It'd be a shame to add this visual "noise" if we don't need it for any non US country. What do you think @AnnWF ?

@Laurabarluzzi yeah we would match the config as we have currently, like well make the Employer Field component and then only have it visible to who needs it

Thanks @Laurabarluzzi for review, and @Cstone until we have the config from yaml, do you want me to limit this for country us now?

@AnnWF I personally think is fine to do introduce the country based conditions later on (I don't want this to be a blocker). But since I didn't have the context on the employer field (I didn't see it in payments) I wasn't sure I was understanding enough for a code review. I approved the patch, since anyway I assume the introduction of geo based settings / options will be introduced at some point in ComboWiki.

Change #1323040 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Add Employer field to all payment method

https://gerrit.wikimedia.org/r/1323040