Page MenuHomePhabricator
Create Task
Maniphest T43316

Null edits produce confirmation
Closed, ResolvedPublic
Actions

Description

Author: swalling

Description:
Currently null edits (https://en.wikipedia.org/wiki/Wikipedia:NULLEDIT#Null_edit) produce a PostEdit message.

This is not a huge problem from the immediate perspective of a user who may have tried to edit a page, since they did technically save their edit even if nothing was changed. However, it is slightly confusing considering that null edits do not produce a new revision in the history.

_If it's not a big pain_, we should consider detecting null edits and not show PostEdit.

Version: unspecified
Severity: minor

Details

Reference
bz41316

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:10 AM
• bzimport added a project: MediaWiki-extensions-PostEdit.
• bzimport set Reference to bz41316.
• bzimport created this task.Oct 23 2012, 6:04 PM
ori added a comment.Oct 23 2012, 6:06 PM

Not a big pain. The ArticleSaveComplete hook sets the $revision parameter to null on null edits:

http://www.mediawiki.org/wiki/Manual:Hooks/ArticleSaveComplete

I'll fix.

ori added a comment.Oct 23 2012, 8:03 PM

Gerrit change 29642.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits