Page MenuHomePhabricator

PagedTiffHandler: The uploaded file contains errors: $1
Closed, ResolvedPublic

Description

'tiff_bad_file' => 'The uploaded file contains errors: $1',

$1 is not substituted

Line 62 of PagedTiffHandler_body.php
if ( !$tr->isValidTiff() ) {

				wfDebug( __METHOD__ . ": bad file\n" );
				$status->fatal( 'tiff_bad_file' );
			}

^ No error parameter passed

Line 102

$error = array( 'tiff_bad_file', PagedTiffHandler::joinMessages( $errors ) );

^ should be ok..

Line 312

return $this->doThumbError( $params, 'tiff_bad_file' );


Version: unspecified
Severity: minor

Details

Reference
bz41318

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:10 AM
bzimport set Reference to bz41318.
Reedy created this task.Oct 23 2012, 6:12 PM

Change 107039 had a related patch set uploaded by 01tonythomas:
Gave a new error message for !isValidTiff()

https://gerrit.wikimedia.org/r/107039

Change 107039 merged by jenkins-bot:
Gave a new error message for !isValidTiff()

https://gerrit.wikimedia.org/r/107039

Gilles moved this task from Untriaged to Done on the Multimedia board.