Page MenuHomePhabricator
Create Task
Maniphest T433318

In Safari on macOS the keyboard shortcut for subscript does not work
Closed, ResolvedPublic
Actions

Description

  1. Open an article in VE in Safari
  2. Select some text
  3. Press cmd + ,

VE claims that the text will become subscripted, but instead the Safari preferences window opens.

This is, unfortunately, the standard macOS shortcut for "open the application's preferences". In Safari you cannot override this, though Chrome allows it.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update VE core submodule to master (2a87b83d4)DLynchmediawiki/extensions/VisualEditormaster+1 -1
TriggerRegistry: don't register a mac shortcut for subscript of cmd+,DLynchVisualEditor/VisualEditormaster+3 -2
Customize query in gerrit

Event Timeline

DLynch created this task.Jul 27 2026, 10:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2026, 10:06 PM
gerritbot added a comment.Jul 27 2026, 10:08 PM

Change #1318308 had a related patch set uploaded (by DLynch; author: DLynch):

[VisualEditor/VisualEditor@master] TriggerRegistry: don't register a mac shortcut for subscript of cmd+,

https://gerrit.wikimedia.org/r/1318308

gerritbot added a project: Patch-For-Review.Jul 27 2026, 10:08 PM
DLynch moved this task from Incoming to Code review on the Editing-team (FY2026-27 Q1 sprint 2) board.Jul 27 2026, 10:08 PM
gerritbot added a comment.Aug 3 2026, 7:17 PM

Change #1318308 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] TriggerRegistry: don't register a mac shortcut for subscript of cmd+,

https://gerrit.wikimedia.org/r/1318308

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2026, 7:31 PM
DLynch added a project: Editing QA.Aug 3 2026, 7:35 PM
DLynch moved this task from Code review to QA on the Editing-team (FY2026-27 Q1 sprint 2) board.
EAkinloose subscribed.Aug 3 2026, 11:24 PM

Since the commit addresses both: cmd + . works in mac, not cmd + ,(inferred behaviour)

EAkinloose edited projects, added: Verified; removed: Editing QA.Aug 3 2026, 11:25 PM
EAkinloose moved this task from QA to Ready for Sign off on the Editing-team (FY2026-27 Q1 sprint 2) board.
DLynch added a comment.Aug 4 2026, 2:29 PM

Since the commit addresses both: cmd + . works in mac, not cmd + ,(inferred behaviour)

Yeah, cmd+ also got switched to ctrl+. for consistency since those two are very much a pair.

ppelberg closed this task as Resolved.Aug 4 2026, 10:39 PM
gerritbot added a comment.Aug 5 2026, 5:40 PM

Change #1321608 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2a87b83d4)

https://gerrit.wikimedia.org/r/1321608

gerritbot added a project: Patch-For-Review.Aug 5 2026, 5:40 PM
gerritbot added a comment.Aug 5 2026, 5:51 PM

Change #1321608 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2a87b83d4)

https://gerrit.wikimedia.org/r/1321608

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.15; 2026-08-11).Aug 5 2026, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 5 2026, 6:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits