[beta & prod] simplified Minerva toolbelt - the Comments counter doesn't reflect the actual number of topics
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Etonkovidova
	Jul 30 2026, 10:21 PM

Project Tags

Referenced Files

	F98893515: Screenshot 2026-08-17 at 3.41.59 PM.png
	Mon, Aug 17, 8:55 PM

	F98331780: MinMin comments without number.png
	Thu, Aug 13, 2:36 PM

	F98331769: MinMin comments with number.png
	Thu, Aug 13, 2:36 PM

Subscribers

View All 11 Subscribers

Description

Steps:
On enwiki beta

Go as a non-logged user go https://en.wikipedia.beta.wmcloud.org/wiki/Chamber_music?minimalMinerva=1
Comments link showed 0 comments. I added two topics.

What happened:

the counter of topics did not increase

The articles with existing topics, e.g. https://en.wikipedia.beta.wmcloud.org/wiki/Polar_bear?minimalMinerva=1, also show 0 comments.

From T434182

I’ve checked one article (Madrid) across the usual target wikis (ar, zh, fr, id, vi, and en) in production (1.47.0-wmf.14): the comments chip displays zero comments for all wikis but zh:

ar should have one
zh displays one, but should have two
fr should have 12
id should have one
vi is correct
en should have 5

NOTE: with 1.47.0-wmf.15, the URL parameter to activate MinMin's toolbar is ?minMinToolbar=1.

NOTE: all target wikis have DiscussionTools in their Special:Version pages.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	[MinMin] Fix comments counter to reflect discussion topics count	Elliottetzkorn	mediawiki/skins/MinervaNeue	master	+9 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		KSarabia-WMF	T428692 Minerva simplified toolbelt bug bash
		Resolved	BUG REPORT	etz	T433647 [beta & prod] simplified Minerva toolbelt - the Comments counter doesn't reflect the actual number of topics

Event Timeline

Etonkovidova created this task.Jul 30 2026, 10:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2026, 10:21 PM

@matthiasmullie this seems related to $parserOutput->getExtensionData( 'DiscussionTools-tocInfo' ) being null on the Beta cluster.

mfossati triaged this task as High priority.Jul 31 2026, 10:32 AM

mfossati added a project: Reader Growth Team (Sprint 3 (Jul 29 - Aug 11) Q1 FY26-27).

mfossati added a parent task: T428692: Minerva simplified toolbelt bug bash.

etz claimed this task.Aug 3 2026, 4:20 PM

etz moved this task from Committed to Doing on the Reader Growth Team (Sprint 3 (Jul 29 - Aug 11) Q1 FY26-27) board.Aug 5 2026, 4:05 PM

lwatson mentioned this in T434182: [MinMin] Comments chip doesn't display the correct number of discussion threads.Fri, Aug 7, 12:17 AM

mfossati closed this task as a duplicate of T434182: [MinMin] Comments chip doesn't display the correct number of discussion threads.Fri, Aug 7, 9:23 AM

mfossati reopened this task as In Progress.Fri, Aug 7, 9:25 AM

mfossati merged a task: T434182: [MinMin] Comments chip doesn't display the correct number of discussion threads.

mfossati added subscribers: etz, lwatson, EBlackorby-WMF and 3 others.

mfossati renamed this task from [beta] simplified Minerva toolbelt - the Comments counter doesn't reflect the actual number of topics to [beta & prod] simplified Minerva toolbelt - the Comments counter doesn't reflect the actual number of topics.Fri, Aug 7, 9:28 AM

mfossati updated the task description. (Show Details)

Change #1324402 had a related patch set uploaded (by Elliottetzkorn; author: Elliottetzkorn):

[mediawiki/skins/MinervaNeue@master] [MinMin] Fix comments counter to reflect discussion topics count

https://gerrit.wikimedia.org/r/1324402

gerritbot added a project: Patch-For-Review.Tue, Aug 11, 9:45 PM

etz moved this task from Doing to Code Review on the Reader Growth Team (Sprint 3 (Jul 29 - Aug 11) Q1 FY26-27) board.Tue, Aug 11, 9:56 PM

etz moved this task from Code Review to QA on the Reader Growth Team (Sprint 3 (Jul 29 - Aug 11) Q1 FY26-27) board.Wed, Aug 12, 4:24 PM

HSwan-WMF moved this task from Sprint 3 (Jul 29 - Aug 11) Q1 FY26-27 to Sprint 4 (Aug 12 - 25) Q1 FY26-27 on the Reader Growth Team board.Wed, Aug 12, 4:28 PM

HSwan-WMF edited projects, added: Reader Growth Team (Sprint 4 (Aug 12 - 25) Q1 FY26-27); removed: Reader Growth Team (Sprint 3 (Jul 29 - Aug 11) Q1 FY26-27).

HSwan-WMF moved this task from Committed to QA on the Reader Growth Team (Sprint 4 (Aug 12 - 25) Q1 FY26-27) board.

SherryYang-WMF lowered the priority of this task from High to Low.Wed, Aug 12, 4:40 PM

lwatson moved this task from QA to Code Review on the Reader Growth Team (Sprint 4 (Aug 12 - 25) Q1 FY26-27) board.Wed, Aug 12, 4:41 PM

etz moved this task from Code Review to QA on the Reader Growth Team (Sprint 4 (Aug 12 - 25) Q1 FY26-27) board.Wed, Aug 12, 4:49 PM

etz moved this task from QA to Code Review on the Reader Growth Team (Sprint 4 (Aug 12 - 25) Q1 FY26-27) board.

lwatson mentioned this in T428690: QA simplified Minerva toolbelt on local/beta/test wiki.Wed, Aug 12, 5:28 PM

lwatson changed the subtype of this task from "Task" to "Bug Report".

Change #1324402 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] [MinMin] Fix comments counter to reflect discussion topics count

https://gerrit.wikimedia.org/r/1324402

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.16; 2026-08-18).Thu, Aug 13, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Thu, Aug 13, 11:31 AM

Verified the counter fix on a wiki page that I created locally.

Notes:

With this change, the number of topics is displayed when (a) DiscussionTools is loaded or (b) when there is 1 or more topics. When that condition is not met, it displays "comments" rather than "0 comments".

MinMin comments with number.png (248×116 px, 9 KB)

MinMin comments without number.png (238×110 px, 8 KB)

Suggestion to replace the "comments" label with "discussions" or something else to represent the talk topics better. Bringing this up in case the intention behind this label was initially for the total number of comments on the talk page and then later changed to the number of topic threads. cc: @JScherer-WMF

lwatson added a subscriber: JScherer-WMF.Thu, Aug 13, 2:53 PM

Already taken into account in the main minmin QA ticket

SherryYang-WMF raised the priority of this task from Low to High.Thu, Aug 13, 10:50 PM

lwatson attached a referenced file: F98331780: MinMin comments without number.png. (Show Details)Mon, Aug 17, 11:49 AM

lwatson attached a referenced file: F98331769: MinMin comments with number.png. (Show Details)

KSarabia-WMF mentioned this in T434653: [MinMin] Launch experiment.Mon, Aug 17, 5:22 PM

Test wiki created on Patch demo by Etonkovidova (WMF) using patch(es) linked to this task:
https://66e682ecb6.catalyst.wmcloud.org/w/

I used ?minMinToolbar=1 for testing, and it works on enwiki wmf.15, but strangely did not work on testwiki wmf.15 and nor on patchdemo that I created: https://66e682ecb6.catalyst.wmcloud.org/wiki/Gail_Sheehy?minMinToolbar=1

I was able to check the fix on enwiki beta (before beta cluster crashed)

the counter correctly reflects the number of topics on the Talk page
the counter correctly increases when the number of topics changes

Screenshot 2026-08-17 at 3.41.59 PM.png (760×1,364 px, 374 KB)

In T433647#12212489, @lwatson wrote:

Verified the counter fix on a wiki page that I created locally.

Notes:

With this change, the number of topics is displayed when (a) DiscussionTools is loaded or (b) when there is 1 or more topics. When that condition is not met, it displays "comments" rather than "0 comments".

Limited testing on beta cluster did not show "comments" for zero comments. I'll test more when beta will be back to normal.

Suggestion to replace the "comments" label with "discussions" or something else to represent the talk topics better. Bringing this up in case the intention behind this label was initially for the total number of comments on the talk page and then later changed to the number of topic threads. cc: @JScherer-WMF

Agree. Should it be "Topics"?
Talk pages differentiate between topics and replies. When a user publish a reply to a topic - the message says: "Your comment was published".

Test wiki created on Patch demo by LWatson-WMF using patch(es) linked to this task:
https://minmin-comments-counter-b9cd5b357748.catalyst.wmcloud.org/wiki/Main Page

Test wiki created on Patch demo by LWatson-WMF using patch(es) linked to this task:
https://a69169a3c6.catalyst.wmcloud.org/wiki/Main Page

Test wiki on Patch demo by LWatson-WMF using patch(es) linked to this task was deleted:

~~https://a69169a3c6.catalyst.wmcloud.org/wiki/Main Page~~

Test wiki on Patch demo by Etonkovidova (WMF) using patch(es) linked to this task was deleted:

~~https://66e682ecb6.catalyst.wmcloud.org/w/~~

Testing Summary:

Re-tested on enwiki beta

the counter correctly reflects the number of topics on the Talk page
the counter correctly increases/decreases when the number of topics changes

Questions

from @lwatson comment - https://phabricator.wikimedia.org/T433647#12212489 - I still did not see that the comments would be present without a counter.
filed T435249: simplified Minerva toolbelt - the Language counter displays count for artciles with no interlanguage links

Test wiki on Patch demo by LWatson-WMF using patch(es) linked to this task was deleted:

~~https://minmin-comments-counter-b9cd5b357748.catalyst.wmcloud.org/wiki/Main Page~~

Looks good. Follow-up ticket T435249 discussed today in standup

Stang unsubscribed.Sun, Aug 23, 8:33 PM

[beta & prod] simplified Minerva toolbelt - the Comments counter doesn't reflect the actual number of topicsClosed, ResolvedPublicBUG REPORTActions