Page MenuHomePhabricator
Create Task
Maniphest T433666

Captions are not displayed on Commons videos (.webm files) although exist .srt files
Closed, ResolvedPublic
Actions

Description

Hi,

I noticed that captions are not working on the Commons videos (.webm files), although I have .srt files for the videos. For example, here is the video file (Commons file) and here is the Macedonian translation (captions), but still when you try to use captions in the file, you cannot find any captions, but you can create captions once again.

I tried to find any other similar issues, and as I did not find, I opened this task. --~~~~

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
TimedText: Include SRT-only sources when listing playback tracksJforrestermediawiki/extensions/TimedMediaHandlerwmf/1.47.0-wmf.13+29 -13
TimedText: Include SRT-only sources when listing playback tracksTheDJmediawiki/extensions/TimedMediaHandlermaster+29 -13
Customize query in gerrit

Related Objects

Event Timeline

Ehrlich91 created this task.Fri, Jul 31, 8:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Jul 31, 8:43 AM
Aklapper edited projects, added: TimedMediaHandler-TimedText; removed: Commons.Fri, Jul 31, 12:25 PM
TheDJ claimed this task.Fri, Jul 31, 3:34 PM
TheDJ added a project: Regression.
TheDJ subscribed.

that's my bad. should be fixed monday or tuesday.

TheDJ triaged this task as Medium priority.Fri, Jul 31, 3:34 PM
gerritbot added a comment.Fri, Jul 31, 4:42 PM

Change #1319882 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] TimedText: Include SRT-only sources when listing playback tracks

https://gerrit.wikimedia.org/r/1319882

gerritbot added a project: Patch-For-Review.Fri, Jul 31, 4:42 PM
TheDJ added a comment.Fri, Jul 31, 4:45 PM

Hmm, this happened due to a last minute rewrite in the track listing where the callers of that function didn't change with the function and of course there was no test coverage :(

gerritbot added a comment.Mon, Aug 3, 1:15 PM

Change #1319882 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] TimedText: Include SRT-only sources when listing playback tracks

https://gerrit.wikimedia.org/r/1319882

Maintenance_bot removed a project: Patch-For-Review.Mon, Aug 3, 1:32 PM
gerritbot added a comment.Mon, Aug 3, 1:34 PM

Change #1320159 had a related patch set uploaded (by Jforrester; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@wmf/1.47.0-wmf.13] TimedText: Include SRT-only sources when listing playback tracks

https://gerrit.wikimedia.org/r/1320159

gerritbot added a project: Patch-For-Review.Mon, Aug 3, 1:34 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.14; 2026-08-04).Mon, Aug 3, 2:00 PM
gerritbot added a comment.Tue, Aug 4, 1:38 PM

Change #1320159 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@wmf/1.47.0-wmf.13] TimedText: Include SRT-only sources when listing playback tracks

https://gerrit.wikimedia.org/r/1320159

Stashbot mentioned this in T427709: Replace tright and tleft with floatright and floatleft in <mapframe>.Tue, Aug 4, 1:38 PM
Stashbot mentioned this in T433703: Interactive map fails to load.

Mentioned in SAL (#wikimedia-operations) [2026-08-04T13:38:48Z] <mszwarc@deploy1003> Started scap sync-world: Backport for [[gerrit:1320171|Thumbnail: Exclude map figures from multimediaviewer (T433703 T427709)]], [[gerrit:1320159|TimedText: Include SRT-only sources when listing playback tracks (T433666)]]

Stashbot added a comment.Tue, Aug 4, 1:41 PM

Mentioned in SAL (#wikimedia-operations) [2026-08-04T13:41:06Z] <mszwarc@deploy1003> mszwarc, jforrester: Backport for [[gerrit:1320171|Thumbnail: Exclude map figures from multimediaviewer (T433703 T427709)]], [[gerrit:1320159|TimedText: Include SRT-only sources when listing playback tracks (T433666)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Tue, Aug 4, 1:48 PM

Mentioned in SAL (#wikimedia-operations) [2026-08-04T13:48:07Z] <mszwarc@deploy1003> Finished scap sync-world: Backport for [[gerrit:1320171|Thumbnail: Exclude map figures from multimediaviewer (T433703 T427709)]], [[gerrit:1320159|TimedText: Include SRT-only sources when listing playback tracks (T433666)]] (duration: 09m 19s)

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.13; 2026-07-28); removed: MW-1.47-notes (1.47.0-wmf.14; 2026-08-04).Tue, Aug 4, 2:00 PM
TheDJ closed this task as Resolved.Tue, Aug 4, 2:21 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Aug 4, 2:31 PM
Aklapper mentioned this in T434172: TimedText not displayed on audio files any longer.Thu, Aug 6, 8:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits