Page MenuHomePhabricator

Add Review Changes personalisation information
Closed, ResolvedPublic3 Estimated Story Points

Description

Updated per comment.

Designs:

Figma

Mobile

1a. Personal dashboard2a. Review changes page3a. Overflow menu4a. Personalization5a. About Review Changes
Mobile_ Personal dashboard.png (360×2,045 px, 135 KB)
Mobile_ All Review changes.png (360×640 px, 47 KB)
Mobile_ Menu.png (360×640 px, 52 KB)
Mobile_ All Review changes-1.png (360×640 px, 45 KB)
Mobile_ About.png (360×640 px, 44 KB)

Desktop

1b. Personal dashboard2b. Review changes page3b. Overflow menu4b. Personalization5b. About Review Changes
Desktop_ Personal dashboard.png (1,440×1,241 px, 142 KB)
Desktop_ All Review changes.png (1,440×800 px, 112 KB)
Desktop_ Menu.png (1,440×800 px, 119 KB)
Desktop_ Personalize.png (1,440×800 px, 126 KB)
Desktop_ About.png (1,440×800 px, 124 KB)

1 - In the new iteration of the module, the description text is moved from the top of the Review changes module to the overflow menu, under About Review changes. On mobile it opens a popover and on desktop, it opens a dialog.
3 - The overflow menu will open 2 items: “Personalization” and “About Review changes”. “Personalization” opens the opportunity to turn on/off the personalization of the module. “About Review changes” opens a popover (mobile) or dialog “Desktop” with the description text.
4 - Popover on mobile and dialog on Desktop with the toggle element. By default, personalization is turned ON.
Title: Personalize Review changes
Toggle switch title: Personalization
Description: Suggests changes using the recommender system. Learn more with the learn more link:
https://www.mediawiki.org/wiki/Home/Recommendations#Review_Changes
5 - Title: About Review changes
Description: These edits were made by other users. Stay up to date and help maintain Wikipedia’s quality by reviewing them.

Popover and dialog without toggle switch
For the intermediate step, below are the modals/dialogs without the toggle in the “Personalization” screen.

MobileDesktop
Mobile_ No toggle.png (360×640 px, 44 KB)
Desktop_ No toggle.png (1,440×800 px, 124 KB)

Additionally, there are updates coming to multiple card design; this is currently in Codex beta
https://doc.wikimedia.org/codex/main/components/demos/card.html#divider
This would change the way that the full page of cards will like eg. after tapping on "See all changes" and more of the changes show in a separate page.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Samwalton9-WMF changed the task status from Open to Stalled.Aug 4 2026, 8:05 AM
Samwalton9-WMF claimed this task.
Samwalton9-WMF moved this task from Inbox to Product backlog on the Moderator-Tools-Team board.

Stalled on me creating that Mediawiki page.

Samwalton9-WMF changed the task status from Stalled to Open.Sep 1 2026, 11:24 AM
Samwalton9-WMF triaged this task as High priority.

We could get started on this, pending the specific link.

It's not entirely accurate yet - related edits will be tackled in T423871, but I think that's OK.

TheresNoTime set the point value for this task to 3.Sep 1 2026, 2:17 PM
TheresNoTime subscribed.

Calling this a 3 due to potential emergent complexity

Change #1333874 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/PersonalDashboard@master] ReviewChanges: explain the feed with a header info popover

https://gerrit.wikimedia.org/r/1333874

Oh just FYI on the design - the above designs were prior to the -> being added, so I've placed the info button as such:

Screenshot 2026-09-07 at 12-24-15.png (824×264 px, 34 KB)

We can swap them around if that makes more sense

Hiya @TheresNoTime! In the coming iterations, there won't be that arrow in the top corner of the module. So you can get rid of the arrow.

Task changing per Planning Meeting, details tbc

TheresNoTime changed the task status from Open to Stalled.Sep 8 2026, 3:26 PM

Stalled pending new designs

Hiya @TheresNoTime!
Here are the updates to the designs (Figma). Let me know if something is missing.

Mobile

1a. Personal dashboard2a. Review changes page3a. Overflow menu4a. Personalization5a. About Review Changes
Mobile_ Personal dashboard.png (360×2,045 px, 135 KB)
Mobile_ All Review changes.png (360×640 px, 47 KB)
Mobile_ Menu.png (360×640 px, 52 KB)
Mobile_ All Review changes-1.png (360×640 px, 45 KB)
Mobile_ About.png (360×640 px, 44 KB)

Desktop

1b. Personal dashboard2b. Review changes page3b. Overflow menu4b. Personalization5b. About Review Changes
Desktop_ Personal dashboard.png (1,440×1,241 px, 142 KB)
Desktop_ All Review changes.png (1,440×800 px, 112 KB)
Desktop_ Menu.png (1,440×800 px, 119 KB)
Desktop_ Personalize.png (1,440×800 px, 126 KB)
Desktop_ About.png (1,440×800 px, 124 KB)

1 - In the new iteration of the module, the description text is moved from the top of the Review changes module to the overflow menu, under About Review changes. On mobile it opens a popover and on desktop, it opens a dialog.
3 - The overflow menu will open 2 items: “Personalization” and “About Review changes”. “Personalization” opens the opportunity to turn on/off the personalization of the module. “About Review changes” opens a popover (mobile) or dialog “Desktop” with the description text.
4 - Popover on mobile and dialog on Desktop with the toggle element. By default, personalization is turned ON.
Title: Personalize Review changes
Toggle switch title: Personalization
Description: Suggests changes using the recommender system. Learn more with the learn more link:
https://www.mediawiki.org/wiki/Home/Recommendations#Review_Changes
5 - Title: About Review changes
Description: These edits were made by other users. Stay up to date and help maintain Wikipedia’s quality by reviewing them.

Popover and dialog without toggle switch
For the intermediate step, below are the modals/dialogs without the toggle in the “Personalization” screen.

MobileDesktop
Mobile_ No toggle.png (360×640 px, 44 KB)
Desktop_ No toggle.png (1,440×800 px, 124 KB)

Additionally, there are updates coming to multiple card design; this is currently in Codex beta
https://doc.wikimedia.org/codex/main/components/demos/card.html#divider
This would change the way that the full page of cards will like eg. after tapping on "See all changes" and more of the changes show in a separate page.

TheresNoTime changed the task status from Stalled to In Progress.Sep 9 2026, 1:36 PM

Looks good (the "Popover and dialog without toggle switch" desktop screenshot seems to be missing the modal but I can infer from the designs) - thank you!

Looks good (the "Popover and dialog without toggle switch" desktop screenshot seems to be missing the modal but I can infer from the designs) - thank you!

Sorry @TheresNoTime, my mistake. I have updated the screenshot now.

Test wiki created on Patch demo by TheresNoTime using patch(es) linked to this task:
https://1f0260b086.catalyst.wmcloud.org/w/

First pass on patchdemo ^

Screenshot 2026-09-09 at 15-56-23.png (1,599×624 px, 165 KB)
Screenshot 2026-09-09 at 15-57-11.png (1,512×781 px, 189 KB)
Screenshot 2026-09-09 at 15-57-42.png (572×873 px, 74 KB)

Think the menu item padding could be a little off, and I note in the design there is a dividing line between the two menu items - this isn't a part of how codex does menu items it seems, but did we want them?

Thanks! The "About Review changes" is in the footer of the menu, which has a divider.

Thanks! The "About Review changes" is in the footer of the menu, which has a divider.

ahhh, thank you!

There's some weird spacing on desktop below the first menu item. Closing the menu and re-opening it seems to resolve the issue:

Screenshot 2026-09-11 at 15.57.25.png (700×424 px, 28 KB)

I wonder if the 'Learn more' link should default to opening in a new tab, to make it easier to continue in the Dashboard afterwards? @OTichonova

Otherwise this is looking good to me!

Samwalton9-WMF renamed this task from Review Changes module info icon to Add Review Changes personalisation information.Sep 11 2026, 2:59 PM

There's some weird spacing on desktop below the first menu item. Closing the menu and re-opening it seems to resolve the issue:

Screenshot 2026-09-11 at 15.57.25.png (700×424 px, 28 KB)

Resolved :)

Test wiki on Patch demo by TheresNoTime using patch(es) linked to this task was deleted:

https://1f0260b086.catalyst.wmcloud.org/w/

Test wiki created on Patch demo by TheresNoTime using patch(es) linked to this task:
https://79932dd109.catalyst.wmcloud.org/w/

Thanks for the work @TheresNoTime, looks good!

Just a couple of small things:

  1. On mobile view there is something happening to the menu when it is open - the menu items are not full menu width.
Screenshot 2026-09-14 at 15.25.31.png (1,002×964 px, 147 KB)
  1. On mobile, when entering the view of all cards. The overflow menu icon is right up against the corner of the screen. Can padding be the same as it is currently for the back arrow? (In designs it is 8px, but there is extra padding around the arrow button, I think the distance from the arrow point to endge of screen is 12px.)
CurrentDesigns
Screenshot 2026-09-14 at 15.22.57.png (1,288×530 px, 82 KB)
Screenshot 2026-09-14 at 15.23.09.png (1,062×380 px, 35 KB)
  1. Not sure if this is part of this ticket, but the module header height is still higher than it should be on the personal dashboard main page for mobile and desktop. The header height for the module should be 46px, while currently it is closer to 61. Once the view of all cards is open on mobile and desktop, the header decreases to the correct height. Can the height of the header section match on both pages?
Dashobard page and all cards view
Screenshot 2026-09-14 at 15.22.08.png (1,420×378 px, 75 KB)

1 and 2 I can definitely address as part of this task, 3 might be pre-existing but will take a look - thank you! :)

Just noting that this patch is going to have some conflicts when T436570: PersonalDashboard: Shared feed REST API for the dashboard feed scaffold lands, so that may be delaying code review (i.e. it probably shouldn't get merged before the scaffold patches, but could still get +1s)

Just noting that this patch is going to have some conflicts when T436570: PersonalDashboard: Shared feed REST API for the dashboard feed scaffold lands, so that may be delaying code review (i.e. it probably shouldn't get merged before the scaffold patches, but could still get +1s)

No conflicts it seems, good to be merged

Change #1333874 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] ReviewChanges: explain the feed from a header overflow menu

https://gerrit.wikimedia.org/r/1333874

Test wiki created on Patch demo by DHardy-WMF using patch(es) linked to this task:
https://e99f391c98.catalyst.wmcloud.org/w/

Test wiki on Patch demo by TheresNoTime using patch(es) linked to this task was deleted by TheresNoTime via DeleteWikis-SingleDelete:

https://79932dd109.catalyst.wmcloud.org/w/