Generator tests should verify that generators are not empty
Open, HighPublicBUG REPORT
Actions

Assigned To

Authored By

	Xqt
	Aug 2 2026, 11:09 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

pywikibot-bugs-list

Xqt

Description

Some generator tests iterate over the returned generator without checking whether it yields any items. If the generator is empty, the test passes without exercising any assertions. The tests should explicitly verify that the generator is not empty.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	tests: Add assertHasItems helper for non-empty iterables	Xqt	pywikibot/core	master	+49 -5

Customize query in gerrit

Event Timeline

Xqt created this task.Aug 2 2026, 11:09 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptAug 2 2026, 11:09 AM

Xqt claimed this task.Aug 2 2026, 11:09 AM

Xqt triaged this task as High priority.

Xqt changed the subtype of this task from "Task" to "Bug Report".

Xqt moved this task from Backlog to New tests needed on the Pywikibot-tests board.

Change #1319943 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] tests: Add assertHasItems helper for non-empty iterables

https://gerrit.wikimedia.org/r/1319943

gerritbot added a project: Patch-For-Review.Aug 2 2026, 12:33 PM

Change #1319943 merged by jenkins-bot: