Page MenuHomePhabricator

[a11y] Minimized toolbar - mw-interlanguage-selector is not keyboard-focusable
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps:

  • on mobile enwiki beta (use ?minimalMinerva=1) go to any article
  • start clicking Tab to go trhough elements on a page
  • the language selector is not keyboard-focusable

Screenshot 2026-08-03 at 3.11.55 PM.png (674×281 px, 41 KB)

<div role="button" href="#p-lang" data-mw="interface" data-event-name="menu.languages" title="Language" class="cdx-info-chip cdx-info-chip--progressive language-selector mw-interlanguage-selector">
            
                <span class="minerva-icon minerva-icon-size-small minerva-icon--language"></span>

                <span class="cdx-info-chip__text">1 language</span>
            
        </div>

Expected behavior:

  • Visible focus, hover, and active affordances
  • Language chip is an anchor tag with button role (<a role="button">)
  • Comments chip is a plain anchor tag (<a>)
  • Both chips are wrapped inside a list container (<ul>/<li>)
  • Language chip is keyboard accessible/focusable via key tabs
  • Enter key activates the language chip/fake button and opens the language selector overlay
  • Screen reader announces language chip as a button

Event Timeline

Change #1321226 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/skins/MinervaNeue@master] Minimal Minerva: make language chip keyboard accessible

https://gerrit.wikimedia.org/r/1321226

Test wiki on Patch demo by LWatson-WMF using patch(es) linked to this task was deleted:

https://071f18d3a6.catalyst.wmcloud.org/wiki/Main Page

Verified the fix locally and on patchdemo (https://1fc44a46e6.catalyst.wmcloud.org/w/index.php?title=Polar_bear&minMinToolbar=1).

Expected behavior:

  • Language chip is an anchor tag with button role (<a role="button">)
  • Comments chip is a plain anchor tag (<a>)
  • Both chips are wrapped inside a list container (<ul>/<li>)
  • Language chip is keyboard accessible/focusable via key tabs
  • Enter key activates the language chip/fake button and opens the language selector overlay
  • Screen reader announces language chip as a button
lwatson changed the subtype of this task from "Task" to "Bug Report".Aug 7 2026, 12:15 AM

Expected behavior:

  • Language chip is an anchor tag with button role (<a role="button">)

  • Comments chip is a plain anchor tag (<a>)

  • Both chips are wrapped inside a list container (<ul>/<li>)

  • Language chip is keyboard accessible/focusable via key tabs

✅, although there's no visible focus/hover affordance, see https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1321226/comment/0b33a32e_26a3644d/

  • Enter key activates the language chip/fake button and opens the language selector overlay

  • Screen reader announces language chip as a button

✅ verified with latest TalkBack on Android 13.

Test wiki on Patch demo by LWatson-WMF using patch(es) linked to this task was deleted:

https://1fc44a46e6.catalyst.wmcloud.org/wiki/Main Page

Change #1321226 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Minimal Minerva: make language chip keyboard accessible

https://gerrit.wikimedia.org/r/1321226

Moving to sign off since Marco and I verified the expected behavior as per the list in the task description.
Note: Elena is out of the office

I had a look at the patch demo. A couple tweaks here. The focus/hover/active states should follow the same rules as a progressive-normal button in Codex. So an outline appears when it's in focus, which is correct based on the screenshots above and the colours shift slightly in the hover and active states, which seem to be missing.

Change #1324743 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/skins/MinervaNeue@master] Minimal Minerva: page chip's active/hover styles

https://gerrit.wikimedia.org/r/1324743

latest patch (1324743) addresses feedback about interactive states. The chip's background color, text color, and icon color change when the chip (anchor element) is active/hover. The styles mirror Codex progressive buttons.

lwatson set the point value for this task to 2.Wed, Aug 12, 3:01 PM

Change #1324743 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Minimal Minerva: page chip's active/hover styles

https://gerrit.wikimedia.org/r/1324743

Test wiki on Patch demo by LWatson-WMF using patch(es) linked to this task was deleted:

https://e7303a21a1.catalyst.wmcloud.org/wiki/Main Page