Page MenuHomePhabricator

It is possible to violate the label-description uniqueness constraint on items
Closed, ResolvedPublic

Description

The uniqueness constraint on label-descriptions can now be violated. This is due to the function itself is modified in TermSqlCache::termsToConditions() (https://gerrit.wikimedia.org/r/#/c/25006/7/repo/includes/store/sql/TermSqlCache.php)

The function could be duplicated into a new with both the functionality of the old and new version of the code, or a new subclass can be made. In the first version a new TermSqlCache::getMatchingTerms() could be made to support it. In the second one the StoreFactory::newTermCache() must be changed.


Version: unspecified
Severity: normal

Details

Reference
bz41390

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:15 AM
bzimport set Reference to bz41390.
bzimport added a subscriber: Unknown Object (MLST).
jeblad created this task.Oct 25 2012, 12:48 PM

This is already fixed on master and we have test cases for it

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 28 2016, 6:03 PM