Page MenuHomePhabricator

Trustly audit mismatch
Closed, ResolvedPublic

Description

Audit file is out by 0.01 because a donation + it's reversal are missing & they left behing a $0.01 fee

Something went amiss with the recon parser while processing /var/spool/audit/trustly/incoming//P11KFUN-3618-20260802120000-20260803120000-0001of0001.csv: "Total amount mismatch : calculated USD 179.61 vs actual 179.60 differenceUSD 0.01"

Looks like we should just accept all 'R codes' at minimum - code comment says "

		// When we get more confident we might permit anything with a non-zero amount
			// but opting in what we see for now https://www.trustly.com/us/blog/a-merchants-guide-to-ach-returns-and-ach-return-codes
			if ( in_array( $row['reason'] ?? '', [ 'AC118', 'R10', 'R08' ], true ) && $row['amount'] && $row['amount'] !== '0.00' ) {

Related Objects

Event Timeline

Change #1320510 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/SmashPig@master] Trustly audit parse - handle all R codes

https://gerrit.wikimedia.org/r/1320510

Change #1320510 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Trustly audit parse - handle all R codes

https://gerrit.wikimedia.org/r/1320510

Change #1324251 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/SmashPig@master] Trustly audit: don't classify R08 Sale leg as reversal_reversed

https://gerrit.wikimedia.org/r/1324251

Change #1324251 merged by Eileen:

[wikimedia/fundraising/SmashPig@master] Trustly audit: don't classify R08 Sale leg as reversal_reversed

https://gerrit.wikimedia.org/r/1324251

Change #1329357 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/SmashPig@master] Add Base62 isValid helper

https://gerrit.wikimedia.org/r/1329357

Change #1329357 abandoned by Eileen:

[wikimedia/fundraising/SmashPig@master] Add Base62 isValid helper

https://gerrit.wikimedia.org/r/1329357

Change #1326997 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/SmashPig@master] Add Base62 isValid helper

https://gerrit.wikimedia.org/r/1326997

Change #1329371 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/SmashPig@master] Audit Trustly - update code to use isValid check

https://gerrit.wikimedia.org/r/1329371

Change #1329384 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/SmashPig@master] Extract getPaymentReconciliationId

https://gerrit.wikimedia.org/r/1329384

Change #1329392 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/SmashPig@master] Trustly: treat all R-code negative legs as chargebacks

https://gerrit.wikimedia.org/r/1329392

Change #1326997 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Add Base62 isValid helper

https://gerrit.wikimedia.org/r/1326997

Change #1329371 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Audit Trustly - update code to use isValid check

https://gerrit.wikimedia.org/r/1329371

Change #1329384 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Extract getPaymentReconciliationId

https://gerrit.wikimedia.org/r/1329384

Change #1329392 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Trustly: treat all R-code negative legs as chargebacks

https://gerrit.wikimedia.org/r/1329392

Eileenmcnaughton claimed this task.
Eileenmcnaughton set Final Story Points to 4.