Page MenuHomePhabricator

[Image Browsing] On-feature hide button
Open, LowPublic1 Estimated Story Points

Description

Designs: https://www.figma.com/design/Pl5dJQk7D6FjIt7GjtXuSX/Image-browsing-scaling?node-id=509-2522

  • selection should persist through session, i.e., once a reader hits Hide, any other pages visited during session will also have carousel in hidden state
  • it is possible for a reader to go to settings and toggle off and back on there as well so the Hide status should reset (i.e., be unhidden) if reader toggles the carousel off and back on in settings.

Event Timeline

HSwan-WMF set the point value for this task to 3.Aug 4 2026, 4:26 PM
SherryYang-WMF removed the point value 3 for this task.
SherryYang-WMF set the point value for this task to 3.

Change #1321157 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/ReaderExperiments@master] WIP: add carousel hide/show state handling

https://gerrit.wikimedia.org/r/1321157

Change #1322192 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/MultimediaViewer@master] Add MMV carousel hide/show state on article pages

https://gerrit.wikimedia.org/r/1322192

Had a look at the implementation to date. It's looking really good! Just a couple of small UI tweaks are needed:

    • The button icon is too big. Icon size should be small. In my mocks that ends up being 10px x 10px for the icon itself
    • The font should also be caption sized. In my mocks that computes as 12px font
  • It's unclear from the video if there's an outline on the button. In its default state, the button shouldn't have a border. It should still follow codex norms for focus, hover, and active states, which all have borders.
  • The button position is a little lower than my mocks, but I think that's ok. It makes it feel clearer that it's a part of the carousel component. No changes necessary.

All of the button changes need to apply to the collapsed state as well.

@KSarabia-WMF after the changes, can you double check the total computed size of the button with those changes to make sure it's at least 24x24 px to meet WCAG AA criteria?

Otherwise it's looking really good!

Change #1321157 abandoned by Kimberly Sarabia:

[mediawiki/extensions/ReaderExperiments@master] WIP: add carousel hide/show state handling

Reason:

Wrong repo

https://gerrit.wikimedia.org/r/1321157

This comment was removed by lwatson.

Filed bug: T435607: Flash of expanded carousel on load (hidden state)
Do you want to resolve in the open patch or as a follow-up?

lwatson changed the point value for this task from 3 to 1.Wed, Aug 26, 4:31 PM