Page MenuHomePhabricator

Remove partial revocation feature from OAuth grant management UI
Open, Needs TriagePublic

Description

The OAuth grant management UI (Special:OAuthManageMyGrants) contains two links per app: revoke access and manage access. The latter gives a checkbox list for the grants the app has, and the user can enable / disable them at will.

This seems like an anti-feature. It means the developer won't know for sure what grants their app actually has; 99% of the time they won't care or even be aware of this, and the user revoking some but not all grants will lead to buggy behavior (and then possibly bogus bug reports and time wasted). It also doesn't help the user who is concerned about giving too many rights to an app, since the app will have all those rights at least for a short time after authorization.

We should either get rid of partial grants revocation, or allow opting out of some grants immediately in the authorization dialog (like e.g. Github lets you do it). I'd go with the former, at least initially.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The revoke access and manage access links are the only way to see what permissions you have given to the app, and "revoke" sounds scary (the link just takes you to a form and doesn't immediately do anything, but this is not obvious upfront). The wording should be rethought.

The "manage access" feature (Special:OAuthManageMyGrants/update) is used around 2 times per day on average on Wikimedia wikis: https://logstash.wikimedia.org/goto/cda6eeeb75b1bf3c600ad6bd52fa009f

For comparison:
The "revoke access" feature (Special:OAuthManageMyGrants/revoke) is used around 5 times per day on average on Wikimedia wikis: https://logstash.wikimedia.org/goto/a0b081565a3bfe110a0c65c69746129b

The revoke access and manage access links are the only way to see what permissions you have given to the app, and "revoke" sounds scary (the link just takes you to a form and doesn't immediately do anything, but this is not obvious upfront). The wording should be rethought.

I would phrase it as "review access".