Page MenuHomePhabricator
Create Task
Maniphest T434111

Use lock manager service in GrowthExperiments
Open, MediumPublic
Actions

Description

See T161749: Standardise lock management in MediaWiki and T366938: Reduce relying on database locks . We are trying to switch off using databases as lock management system.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
refactor: Migrate to the lock manager serviceUrbanecmmediawiki/extensions/GrowthExperimentsmaster+25 -30
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Wed, Aug 5, 4:21 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptWed, Aug 5, 4:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ladsgroup added a comment.Wed, Aug 5, 4:22 PM

See as an example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1318312

Urbanecm_WMF triaged this task as Medium priority.Wed, Aug 5, 4:37 PM
Urbanecm_WMF moved this task from Inbox to Needs Estimation on the Growth-Team board.
Urbanecm_WMF added a project: Growth Team Maintenance.
Urbanecm_WMF subscribed.

This basically means switching to ILockManager::lockKey (or preferably, ILockManager::scopedLock).

Michael subscribed.Thu, Aug 6, 12:13 PM
gerritbot added a comment.Thu, Aug 6, 7:11 PM

Change #1322075 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] tests: Reuse newReassignMentees helper in ReassignMenteesTest

https://gerrit.wikimedia.org/r/1322075

gerritbot added a project: Patch-For-Review.Thu, Aug 6, 7:11 PM

Change #1322076 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] refactor: Migrate to the lock manager service

https://gerrit.wikimedia.org/r/1322076

Urbanecm_WMF claimed this task.Thu, Aug 6, 7:11 PM
gerritbot added a comment.Fri, Aug 7, 4:55 PM

Change #1322076 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: Migrate to the lock manager service

https://gerrit.wikimedia.org/r/1322076

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.15; 2026-08-11).Fri, Aug 7, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits