Page MenuHomePhabricator
Create Task
Maniphest T434190

AbuseLogLookup::getHitCountsForUsers skips hits during account creation
Open, Needs TriagePublicBUG REPORT
Actions

Description

AbuseLogLookup::getHitCountsForUsers filters the abuse log entries using just the user id (afl_user). However, createaccount and autocreateaccount actions have afl_user = 0 in their log entries, despite having the user name in afl_user_text.

The method should be changed so that it accepts an array of UserIdentity'ies and prepares the condition using AbuseLogConditionFactory.

This is similar to T213982

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Drop backward-compatibility for T434190Mszwarcmediawiki/extensions/CheckUsermaster+2 -4
Update getHitCountsForUsers to pass UserIdentity[] and use string keyMszwarcmediawiki/extensions/CheckUsermaster+5 -3
AbuseLogLookup: Fix counting hits on account creationMszwarcmediawiki/extensions/AbuseFiltermaster+25 -21
AbuseLogLookup::getHitCountsForUsers: Accept UserIdentity[] as paramMszwarcmediawiki/extensions/AbuseFiltermaster+14 -8
Customize query in gerrit

Related Objects

Event Timeline

mszwarc created this task.Aug 6 2026, 12:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2026, 12:10 PM
mszwarc claimed this task.Aug 6 2026, 12:10 PM
mszwarc moved this task from Backlog to In progress on the Product Safety and Integrity (Sprint Clover (Jul 20 - Aug 7)) board.
gerritbot added a comment.Aug 6 2026, 1:22 PM

Change #1321950 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CheckUser@master] Update getHitCountsForUsers to pass UserIdentity[] and use string key

https://gerrit.wikimedia.org/r/1321950

gerritbot added a project: Patch-For-Review.Aug 6 2026, 1:22 PM

Change #1321952 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/AbuseFilter@master] AbuseLogLookup::getHitCountsForUsers: Accept UserIdentity[] as param

https://gerrit.wikimedia.org/r/1321952

gerritbot added a comment.Aug 6 2026, 1:22 PM

Change #1321951 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CheckUser@master] Drop backward-compatibility for T434190

https://gerrit.wikimedia.org/r/1321951

gerritbot added a comment.Aug 6 2026, 1:22 PM

Change #1321953 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/AbuseFilter@master] AbuseLogLookup: Fix counting hits on account creation

https://gerrit.wikimedia.org/r/1321953

mszwarc moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Clover (Jul 20 - Aug 7)) board.Aug 6 2026, 1:47 PM
OKryva-WMF edited projects, added: Product Safety and Integrity (Sprint Sunflower (Aug 11 - Aug 28)); removed: Product Safety and Integrity (Sprint Clover (Jul 20 - Aug 7)).Tue, Aug 11, 1:56 PM
OKryva-WMF moved this task from Backlog to Needs review on the Product Safety and Integrity (Sprint Sunflower (Aug 11 - Aug 28)) board.Tue, Aug 11, 1:56 PM
gerritbot added a comment.Fri, Aug 14, 2:32 PM

Change #1321952 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] AbuseLogLookup::getHitCountsForUsers: Accept UserIdentity[] as param

https://gerrit.wikimedia.org/r/1321952

gerritbot added a comment.Fri, Aug 14, 2:33 PM

Change #1321950 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Update getHitCountsForUsers to pass UserIdentity[] and use string key

https://gerrit.wikimedia.org/r/1321950

gerritbot added a comment.Fri, Aug 14, 2:34 PM

Change #1321953 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] AbuseLogLookup: Fix counting hits on account creation

https://gerrit.wikimedia.org/r/1321953

gerritbot added a comment.Fri, Aug 14, 2:34 PM

Change #1321951 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Drop backward-compatibility for T434190

https://gerrit.wikimedia.org/r/1321951

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.16; 2026-08-18).Fri, Aug 14, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, Aug 14, 3:31 PM
mszwarc moved this task from Needs review to QA in Prod on the Product Safety and Integrity (Sprint Sunflower (Aug 11 - Aug 28)) board.Tue, Aug 18, 11:54 AM
OKryva-WMF edited projects, added: Product Safety and Integrity (Sprint Heather (Aug 31 - Sept 18)); removed: Product Safety and Integrity (Sprint Sunflower (Aug 11 - Aug 28)).Wed, Sep 2, 11:28 AM
OKryva-WMF moved this task from Backlog to QA in Prod on the Product Safety and Integrity (Sprint Heather (Aug 31 - Sept 18)) board.Wed, Sep 2, 11:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits