Maniphest T434270

PHPUnit test Wikimedia\Tests\ObjectCache\WANObjectCacheTest::testLockTSE_stale is flaky
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Fri, Aug 7, 7:42 AM

Project Tags

Referenced Files

None

Subscribers

Description

On https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1320176 a unrelated test fails, but passed for other CI runs on the same patch set.

https://integration.wikimedia.org/ci/job/quibble-for-mediawiki-core-vendor-sqlite-php83/4046/console

There was 1 failure:

1) Wikimedia\Tests\ObjectCache\WANObjectCacheTest::testLockTSE_stale with data set #1 (array('/*/test/', 'hash_stop'), '|#|')
Cache hit value again
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'bar'
+'baz'

/workspace/src/tests/phpunit/unit/includes/libs/ObjectCache/WANObjectCacheTest.php:1321

Also happen for https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php84/20717/console on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Lockdown/+/1322556

Last changes from 66c6cf7f2bcbb33591242b846199fd85fd4c8712 / T424357

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	WANObjectCache: Fix flaky testLockTSE_stale	Kosta Harlan	mediawiki/core	master	+28 -7

Customize query in gerrit

Related Objects

Mentioned Here: rMW66c6cf7f2bcb: WANObjectCache: Change lockTSE test to not use since/lag options
T424357: Remove lag protection from WANObjectCache

Event Timeline

Umherirrender created this task.Fri, Aug 7, 7:42 AM

Restricted Application added a project: MediaWiki-Core-Platform-Team. · View Herald TranscriptFri, Aug 7, 7:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• matmarex moved this task from Inbox, needs triage to Kanban on the MediaWiki-Core-Platform-Team board.Tue, Aug 11, 2:17 PM

• matmarex edited projects, added: MediaWiki-Core-Platform-Team (Kanban); removed: MediaWiki-Core-Platform-Team.

Michael subscribed.Thu, Aug 13, 4:51 PM

Reedy merged a task: T435226: Wikimedia\Tests\ObjectCache\WANObjectCacheTest::testLockTSE_stale with data set #0 (array('hash_tag'), '{') test failure.Tue, Aug 18, 4:36 PM

Reedy subscribed.

Change #1326989 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] WANObjectCache: Fix flaky testLockTSE_stale

https://gerrit.wikimedia.org/r/1326989

gerritbot added a project: Patch-For-Review.Wed, Aug 19, 6:31 AM

kostajh claimed this task.Wed, Aug 19, 6:32 AM

Change #1326989 merged by jenkins-bot:

[mediawiki/core@master] WANObjectCache: Fix flaky testLockTSE_stale

https://gerrit.wikimedia.org/r/1326989

kostajh closed this task as Resolved.Wed, Aug 19, 1:23 PM

Maintenance_bot removed a project: Patch-For-Review.Wed, Aug 19, 1:31 PM

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.17; 2026-08-25).Wed, Aug 19, 2:00 PM