🐋 Handle exceptions that can occur while saving the lexeme
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jakob_WMDE
	Aug 10 2026, 1:30 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Jakob_WMDE

Description

Resource too large
Edit prevented (abusefilter etc)
Rate limiting
Temp account creation limits
...?

It might make sense to split this into multiple sub tasks.

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
REST: Update ADR 11	Silvan Heintze	mediawiki/extensions/Wikibase	master	+2 -0
REST: Add unit tests for EntityUpdater exceptions	Silvan Heintze	mediawiki/extensions/WikibaseLexeme	master	+61 -7
REST: Introduce UpdateExceptionHandler	Silvan Heintze	mediawiki/extensions/WikibaseLexeme	master	+29 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T428629 [Epic] REST API endpoints for lexemes
Resolved	Jakob_WMDE	T428926 🐋 Create a lexeme in the Wikibase REST API
Resolved	Silvan_WMDE	T434441 🐋 Handle exceptions that can occur while saving the lexeme
Resolved	Silvan_WMDE	T436118 🐋 Handle ResourceTooLargeException while saving the lexeme
Resolved	kimpham	T436119 🐋 Handle EditPrevented while saving the lexeme
Resolved	ItamarWMDE	T436120 🐋 Handle RateLimitReached while saving the lexeme
Resolved	Silvan_WMDE	T436121 🐋 Handle EntityUpdateFailed while saving the lexeme

Event Timeline

Jakob_WMDE created this task.Aug 10 2026, 1:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2026, 1:30 PM

Ifrahkhanyaree_WMDE edited projects, added: Wikibase Reuse Team (Sprint 76); removed: Wikibase Reuse Team (Sprint 75).Aug 19 2026, 11:01 AM

Silvan_WMDE claimed this task.Aug 26 2026, 7:58 AM

Silvan_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 76) board.

Silvan_WMDE created subtask T436118: 🐋 Handle ResourceTooLargeException while saving the lexeme.Aug 26 2026, 2:47 PM

Silvan_WMDE created subtask T436119: 🐋 Handle EditPrevented while saving the lexeme.

Silvan_WMDE created subtask T436120: 🐋 Handle RateLimitReached while saving the lexeme.

Silvan_WMDE created subtask T436121: 🐋 Handle EntityUpdateFailed while saving the lexeme.

Change #1329584 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/WikibaseLexeme@master] REST: Introduce UpdateExceptionHandler

https://gerrit.wikimedia.org/r/1329584

gerritbot added a project: Patch-For-Review.Aug 26 2026, 2:57 PM

Change #1329584 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] REST: Introduce UpdateExceptionHandler

https://gerrit.wikimedia.org/r/1329584

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2026, 3:31 PM

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.18; 2026-09-01).Aug 27 2026, 4:00 PM

Ifrahkhanyaree_WMDE edited projects, added: Wikibase Reuse Team (Sprint 77); removed: Wikibase Reuse Team (Sprint 76).Sep 2 2026, 9:31 AM

Ifrahkhanyaree_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 77) board.

Ifrahkhanyaree_WMDE closed subtask T436118: 🐋 Handle ResourceTooLargeException while saving the lexeme as Resolved.Sep 2 2026, 9:52 AM

Ifrahkhanyaree_WMDE closed subtask T436120: 🐋 Handle RateLimitReached while saving the lexeme as Resolved.

Change #1333879 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/WikibaseLexeme@master] REST: Add unit tests for EntityUpdater exceptions

https://gerrit.wikimedia.org/r/1333879

gerritbot added a project: Patch-For-Review.Sep 2 2026, 2:35 PM

Change #1333879 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] REST: Add unit tests for EntityUpdater exceptions

https://gerrit.wikimedia.org/r/1333879

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.19; 2026-09-08); removed: MW-1.47-notes (1.47.0-wmf.18; 2026-09-01).Sep 3 2026, 9:01 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2026, 9:33 AM

The case of EntityUpdateFailed (see T436121) reveils some ongoing confusion about our way of handling exceptions and declaring them via @throws annotation.

Some examples from the EntityUpdater:

StorageException is a RuntimeException that is being handled in some cases and re-thrown as "unexpected" in others, but not declared
EntityUpdateFailed is declared via @throws but treated as “unexpected” - it could be a RuntimeException instead and not be declared
ReadOnlyError is not a RuntimeException but neither declared nor handled (effectively also treated as “unexpected”), causing IDE complaints

Maybe this should be reflected in ADR 11 by enhancing the part that says "unless they are not expected to be caught" with examples that are not handled by application code and eventually caught by the UnexpectedErrorHandlerMiddleware

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 77) board.Sep 4 2026, 8:17 AM

Change #1338776 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Update ADR 11

https://gerrit.wikimedia.org/r/1338776

gerritbot added a project: Patch-For-Review.Thu, Sep 10, 10:12 AM

Change #1338776 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Update ADR 11

https://gerrit.wikimedia.org/r/1338776

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.20; 2026-09-15); removed: MW-1.47-notes (1.47.0-wmf.19; 2026-09-08).Mon, Sep 14, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mon, Sep 14, 2:31 PM

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 77) board.Tue, Sep 15, 9:02 AM

Ifrahkhanyaree_WMDE closed this task as Resolved.Thu, Sep 17, 8:55 AM