Page MenuHomePhabricator

[MinMin] Disable Comments chip in wikis where talk pages aren't allowed
Closed, ResolvedPublicBUG REPORT

Description

Standard Minerva doesn't show the talk page tab in all target Wikipedias (ar, zh, fr, id, vi) but en.
MinMin toolbar should comply with that behavior, see design.

Acceptance criteria

Event Timeline

Change #1324403 had a related patch set uploaded (by Elliottetzkorn; author: Elliottetzkorn):

[mediawiki/skins/MinervaNeue@master] [MinMin] Disable Comments chip in wikis where talk pages aren't allowed

https://gerrit.wikimedia.org/r/1324403

Standard Minerva doesn't show the talk page tab in all target Wikipedias (ar, zh, fr, id, vi) but en.

This is controlled by $wgMinervaTalkAtTop NOT user permissions. MinervaPagePermissions->isTalkAllowed() is only an abstraction for user permissions (which is related to global site blocks). Are you sure thast's what you want? If you want the former please use $featuresManager->isFeatureAvailableForCurrentUser( 'MinervaTalkAtTop' )

SherryYang-WMF lowered the priority of this task from High to Low.Wed, Aug 12, 4:40 PM

Change #1324403 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] [MinMin] Disable Comments chip in wikis where talk pages aren't allowed

https://gerrit.wikimedia.org/r/1324403

SherryYang-WMF raised the priority of this task from Low to High.Thu, Aug 13, 10:50 PM
Etonkovidova subscribed.

Checked on arwiki beta and viwiki beta- the lang selector is displayed; the link to a talk page is not displayed - according to the design.

KSarabia-WMF subscribed.

Looks good. Signing off.